Fixing squid:S2111, squid:S1118, squid:S3008

Faisal Hameed · Faisal Hameed · commit f598284eae45 · 2016-02-28T22:09:16.000+05:00
diff --git a/src/main/java/com/cedarsoftware/util/Converter.java b/src/main/java/com/cedarsoftware/util/Converter.java
@@ -301,8 +301,8 @@ else if (fromInstance instanceof String)
                         return new BigDecimal(((String) fromInstance).trim());
                     }
                     else if (fromInstance instanceof Number)
-                    {
-                        return new BigDecimal(((Number) fromInstance).doubleValue());
+                    {                        
+                        return BigDecimal.valueOf(((Number) fromInstance).doubleValue());
                     }
                     else if (fromInstance instanceof Boolean)
                     {
diff --git a/src/main/java/com/cedarsoftware/util/DeepEquals.java b/src/main/java/com/cedarsoftware/util/DeepEquals.java
@@ -50,6 +50,8 @@
  */
 public class DeepEquals
 {
+    private DeepEquals () {}
+    
     private static final Map<Class, Boolean> _customEquals = new ConcurrentHashMap<>();
     private static final Map<Class, Boolean> _customHash = new ConcurrentHashMap<>();
     private static final double doubleEplison = 1e-15;
diff --git a/src/main/java/com/cedarsoftware/util/UniqueIdGenerator.java b/src/main/java/com/cedarsoftware/util/UniqueIdGenerator.java
@@ -31,6 +31,8 @@
  */
 public class UniqueIdGenerator
 {
+    private UniqueIdGenerator () {}
+    
     private static int count = 0;
     private static final int lastIp;
     private static final Map<Long, Long> lastId = new LinkedHashMap<Long, Long>()
diff --git a/src/main/java/com/cedarsoftware/util/UrlInvocationHandler.java b/src/main/java/com/cedarsoftware/util/UrlInvocationHandler.java
@@ -57,7 +57,7 @@
  */
 public class UrlInvocationHandler implements InvocationHandler
 {
-    public static int SLEEP_TIME = 5000;
+    public static final int SLEEP_TIME = 5000;
     private final Logger LOG = LogManager.getLogger(UrlInvocationHandler.class);
     private final UrlInvocationHandlerStrategy _strategy;
 

Original file line number	Diff line number	Diff line change
`@@ -301,8 +301,8 @@ else if (fromInstance instanceof String)`
`301`	`301`	`return new BigDecimal(((String) fromInstance).trim());`
`302`	`302`	`}`
`303`	`303`	`else if (fromInstance instanceof Number)`
`304`		`- {`
`305`		`- return new BigDecimal(((Number) fromInstance).doubleValue());`
	`304`	`+ {`
	`305`	`+ return BigDecimal.valueOf(((Number) fromInstance).doubleValue());`
`306`	`306`	`}`
`307`	`307`	`else if (fromInstance instanceof Boolean)`
`308`	`308`	`{`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,8 @@`
`50`	`50`	`*/`
`51`	`51`	`public class DeepEquals`
`52`	`52`	`{`
	`53`	`+ private DeepEquals () {}`
	`54`	`+`
`53`	`55`	`private static final Map<Class, Boolean> _customEquals = new ConcurrentHashMap<>();`
`54`	`56`	`private static final Map<Class, Boolean> _customHash = new ConcurrentHashMap<>();`
`55`	`57`	`private static final double doubleEplison = 1e-15;`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,8 @@`
`31`	`31`	`*/`
`32`	`32`	`public class UniqueIdGenerator`
`33`	`33`	`{`
	`34`	`+ private UniqueIdGenerator () {}`
	`35`	`+`
`34`	`36`	`private static int count = 0;`
`35`	`37`	`private static final int lastIp;`
`36`	`38`	`private static final Map<Long, Long> lastId = new LinkedHashMap<Long, Long>()`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@`
`57`	`57`	`*/`
`58`	`58`	`public class UrlInvocationHandler implements InvocationHandler`
`59`	`59`	`{`
`60`		`- public static int SLEEP_TIME = 5000;`
	`60`	`+ public static final int SLEEP_TIME = 5000;`
`61`	`61`	`private final Logger LOG = LogManager.getLogger(UrlInvocationHandler.class);`
`62`	`62`	`private final UrlInvocationHandlerStrategy _strategy;`
`63`	`63`