Make reqwest use native-tls

jmmv · jmmv · commit 76143799c6a5 · 2021-12-07T16:41:24.000-08:00
The new 0.11.7 release of reqwest depends on rustls-0.20, which does not
work with our MSRV (1.48).  We could downgrade our dependency on reqwest
to pin it to 0.11.6, or we could avoid rustls.

Given that the native tls dependency is ubiquitous, it seems easy enough
to side-step the problem this way.  As a side benefit, we should get a
slightly faster build because we are not building rustls in the common
case.

The only problem is the cross-compilation of the Raspberry Pi build, but
we can side-step that by using rustls in that single case.

Confirmed that the web interface continues to work after this change.
diff --git a/.github/workflows/release.sh b/.github/workflows/release.sh
@@ -63,6 +63,9 @@ main() {
         linux-armv7-rpi)
             [ ! -f .cargo/config ] || err "Won't override existing .cargo/config"
             cp .cargo/config.rpi .cargo/config
+            # TODO(jmmv): Should figure out how to cross-compile with the native TLS library
+            # instead of doing this hack.
+            sed -i s,native-tls,rustls-tls,g std/Cargo.toml
             # TODO(jmmv): Should enable --features=sdl but need to figure out how to cross-build
             # for it.
             ( cd cli && cargo build --release --verbose --features=rpi )
diff --git a/std/Cargo.toml b/std/Cargo.toml
@@ -39,7 +39,7 @@ features = ["small_rng", "std", "std_rng"]
 [dependencies.reqwest]
 version = "0.11"
 default-features = false
-features = ["rustls-tls"]
+features = ["native-tls"]
 
 [dev-dependencies]
 flate2 = "1.0"
