Skip to content

Commit 10a62a8

Browse files
committed
Only upload zip files to the release
Uploading tgzs seems to cause GitHub to wrap them in a zip which is pretty pointless. The Windows release binary looks fine because it was always uploaded as a zip, but the macOS and Linux binaries looked odd. This should resolve the problem.
1 parent bffe68d commit 10a62a8

File tree

2 files changed

+1
-27
lines changed

2 files changed

+1
-27
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -93,19 +93,6 @@ jobs:
9393
draft: true
9494
prerelease: false
9595
token: ${{ secrets.GITHUB_TOKEN }}
96-
- name: Upload tgz artifacts
97-
id: upload_tgzs
98-
uses: ncipollo/release-action@v1
99-
with:
100-
allowUpdates: true
101-
omitBody: true
102-
omitName: true
103-
replacesArtifacts: false
104-
draft: true
105-
prerelease: false
106-
artifacts: "artifacts/*/*.tgz"
107-
artifactContentType: application/gzip
108-
token: ${{ secrets.GITHUB_TOKEN }}
10996
- name: Upload zip artifacts
11097
id: upload_zips
11198
uses: ncipollo/release-action@v1

.github/workflows/release.sh

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ main() {
6666
echo
6767
done >"${distname}/NOTICE"
6868

69-
local ext=
7069
local target=
7170
case "${name}" in
7271
linux-armv7-rpi)
@@ -81,8 +80,6 @@ main() {
8180
rm -f .cargo/config
8281

8382
cp ./target/armv7-unknown-linux-gnueabihf/release/endbasic "${distname}"
84-
85-
ext=tgz
8683
;;
8784

8885
macos*)
@@ -110,7 +107,6 @@ main() {
110107

111108
brew uninstall --ignore-dependencies sdl2 sdl2_ttf freetype libpng
112109
sanity_check "${distname}/endbasic"
113-
ext=tgz
114110
;;
115111

116112
windows*)
@@ -120,7 +116,6 @@ main() {
120116
cp dlls/* "${distname}"
121117

122118
sanity_check "${distname}/endbasic.exe"
123-
ext=zip
124119
;;
125120

126121
*)
@@ -129,17 +124,9 @@ main() {
129124
cp ./target/release/endbasic "${distname}"
130125

131126
sanity_check "${distname}/endbasic"
132-
ext=tgz
133-
;;
134-
esac
135-
case "${ext}" in
136-
tgz)
137-
tar czvf "${outdir}/${distname}.${ext}" "${distname}"
138-
;;
139-
zip)
140-
zip -r "${outdir}/${distname}.${ext}" "${distname}"
141127
;;
142128
esac
129+
zip -r "${outdir}/${distname}.zip" "${distname}"
143130
rm -rf "${distname}"
144131
}
145132

0 commit comments

Comments
 (0)