constructors: don't warn about missing constructor if class only has static variable members

Daniel Marjamäki · Daniel Marjamäki · commit d8927e720d36 · 2009-02-21T13:35:55.000Z
diff --git a/src/checkclass.cpp b/src/checkclass.cpp
@@ -79,7 +79,7 @@ struct CheckClass::VAR *CheckClass::ClassChecking_GetVarList(const Token *tok1)
         // If next token contains a ":".. it is not part of a variable declaration
         if (next->str().find(":") != std::string::npos)
         {
-        
+
         }
 
         // Is it a variable declaration?
@@ -91,28 +91,12 @@ struct CheckClass::VAR *CheckClass::ClassChecking_GetVarList(const Token *tok1)
                 varname = next->strAt(1);
         }
 
-        // Is it a variable declaration?
-        else if (Token::Match(next, "%type% %type% %var% ;"))
-        {
-            const Token *next2 = next->next();
-            if (next2->isStandardType())
-                varname = next2->strAt(1);
-            else if (Token::findmatch(_tokenizer->tokens(), ("enum " + next2->str()).c_str()))
-                varname = next2->strAt(1);
-        }
-
         // Pointer?
         else if (Token::Match(next, "%type% * %var% ;"))
         {
             varname = next->strAt(2);
         }
 
-        // Pointer?
-        else if (!b && Token::Match(next, "%type% %type% * %var% ;"))
-        {
-            varname = next->strAt(3);
-        }
-
         // If the varname was set in one of the two if-block above, create a entry for this variable..
         if (varname)
         {
diff --git a/src/tokenize.cpp b/src/tokenize.cpp
@@ -482,6 +482,22 @@ void Tokenizer::tokenize(std::istream &code, const char FileName[])
             tok->deleteNext();
         }
     }
+
+    // Remove "mutable"
+    while (Token::simpleMatch(_tokens, "mutable"))
+    {
+        Token *tok = _tokens;
+        _tokens = _tokens->next();
+        delete tok;
+    }
+    for (Token *tok = _tokens; tok; tok = tok->next())
+    {
+        while (Token::simpleMatch(tok->next(), "mutable"))
+        {
+            tok->deleteNext();
+        }
+    }
+
 }
 //---------------------------------------------------------------------------
 
diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -51,6 +51,9 @@ class TestClass : public TestFixture
         TEST_CASE(uninitVarHeader1);    // Class is defined in header
         TEST_CASE(uninitVarHeader2);    // Class is defined in header
         TEST_CASE(uninitVarHeader3);    // Class is defined in header
+
+        TEST_CASE(noConstructor1);
+        TEST_CASE(noConstructor2);
     }
 
     // Check that base classes have virtual destructors
@@ -296,6 +299,61 @@ class TestClass : public TestFixture
     }
 
 
+
+
+
+    void checkNoConstructor(const char code[])
+    {
+        // Tokenize..
+        Tokenizer tokenizer;
+        std::istringstream istr(code);
+        tokenizer.tokenize(istr, "test.cpp");
+        tokenizer.simplifyTokenList();
+
+        // Clear the error log
+        errout.str("");
+
+        // Check..
+        Settings settings;
+        settings._checkCodingStyle = true;
+        CheckClass checkClass(&tokenizer, settings, this);
+        checkClass.constructors();
+    }
+
+    void noConstructor1()
+    {
+        // There are nonstatic member variables - constructor is needed
+        checkNoConstructor("class Fred\n"
+                           "{\n"
+                           "    int i;\n"
+                           "};\n");
+        ASSERT_EQUALS("[test.cpp:1]: (style) The class 'Fred' has no constructor\n", errout.str());
+    }
+
+    void noConstructor2()
+    {
+        checkNoConstructor("class Fred\n"
+                           "{\n"
+                           "public:\n"
+                           "    static void foobar();\n"
+                           "};\n"
+                           "\n"
+                           "void Fred::foobar()\n"
+                           "{ }\n");
+        ASSERT_EQUALS("", errout.str());
+    }
+
+    void noConstructor3()
+    {
+        checkNoConstructor("class Fred\n"
+                           "{\n"
+                           "public:\n"
+                           "    static int foobar;\n"
+                           "};\n");
+        ASSERT_EQUALS("", errout.str());
+    }
+
+
 };
 
 REGISTER_TEST(TestClass)

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ struct CheckClass::VAR CheckClass::ClassChecking_GetVarList(const Token tok1)`
`79`	`79`	`// If next token contains a ":".. it is not part of a variable declaration`
`80`	`80`	`if (next->str().find(":") != std::string::npos)`
`81`	`81`	`{`
`82`		`-`
	`82`	`+`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`// Is it a variable declaration?`
`@@ -91,28 +91,12 @@ struct CheckClass::VAR CheckClass::ClassChecking_GetVarList(const Token tok1)`
`91`	`91`	`varname = next->strAt(1);`
`92`	`92`	`}`
`93`	`93`
`94`		`- // Is it a variable declaration?`
`95`		`- else if (Token::Match(next, "%type% %type% %var% ;"))`
`96`		`- {`
`97`		`- const Token *next2 = next->next();`
`98`		`- if (next2->isStandardType())`
`99`		`- varname = next2->strAt(1);`
`100`		`- else if (Token::findmatch(_tokenizer->tokens(), ("enum " + next2->str()).c_str()))`
`101`		`- varname = next2->strAt(1);`
`102`		`- }`
`103`		`-`
`104`	`94`	`// Pointer?`
`105`	`95`	`else if (Token::Match(next, "%type% * %var% ;"))`
`106`	`96`	`{`
`107`	`97`	`varname = next->strAt(2);`
`108`	`98`	`}`
`109`	`99`
`110`		`- // Pointer?`
`111`		`- else if (!b && Token::Match(next, "%type% %type% * %var% ;"))`
`112`		`- {`
`113`		`- varname = next->strAt(3);`
`114`		`- }`
`115`		`-`
`116`	`100`	`// If the varname was set in one of the two if-block above, create a entry for this variable..`
`117`	`101`	`if (varname)`
`118`	`102`	`{`