[#59817096]Support Errno::ENETUNREACH

Glyn Normington · Glyn Normington · commit 3d76f80f1df9 · 2013-10-30T10:12:01.000Z
The internet availability check was failing because Errno::ENETUNREACH was not being handled. This fix adds Errno::ENETUNREACH and a number of other network-related exceptions to the set being handled. When these errors are caught on the first download attempt in a buildpack invocation (detect, compile, or release), the internet is deemed to be inaccessible and a look- aside is performed in the (currently read-only, but pre-populated) buildpack cache. See https://www.pivotaltracker.com/s/projects/803319/stories/58941750 for background. [#59817096]
diff --git a/lib/java_buildpack/util/download_cache.rb b/lib/java_buildpack/util/download_cache.rb
@@ -105,10 +105,17 @@ def evict(uri)
 
     HTTP_ERRORS = [
         EOFError,
+        Errno::ECONNABORTED,
         Errno::ECONNREFUSED,
         Errno::ECONNRESET,
+        Errno::EHOSTDOWN,
         Errno::EHOSTUNREACH,
         Errno::EINVAL,
+        Errno::ENETDOWN,
+        Errno::ENETRESET,
+        Errno::ENETUNREACH,
+        Errno::ENONET,
+        Errno::ENOTCONN,
         Errno::EPIPE,
         Errno::ETIMEDOUT,
         Net::HTTPBadResponse,
diff --git a/spec/java_buildpack/util/download_cache_spec.rb b/spec/java_buildpack/util/download_cache_spec.rb
@@ -355,6 +355,23 @@ def suppress_internet_availability_check
       end
     end
 
+    it 'should use the buildpack cache if the download cannot be completed because Errno::ENETUNREACH is raised' do
+      stub_request(:get, 'http://foo-uri/').to_raise(Errno::ENETUNREACH)
+
+      Dir.mktmpdir do |root|
+        Dir.mktmpdir do |buildpack_cache|
+          java_buildpack_cache = File.join(buildpack_cache, 'java-buildpack')
+          FileUtils.mkdir_p java_buildpack_cache
+          touch java_buildpack_cache, 'cached', 'foo-stashed'
+          with_buildpack_cache(buildpack_cache) do
+            DownloadCache.new(root).get('http://foo-uri/') do |file|
+              expect(file.read).to eq('foo-stashed')
+            end
+          end
+        end
+      end
+    end
+
     it 'should use the buildpack cache if the cache configuration disables remote downloads' do
       YAML.stub(:load_file).with(File.expand_path('config/cache.yml')).and_return(
           'remote_downloads' => 'disabled')
