get to a nicer state

runspired · runspired · commit f8dd32214bad · 2018-09-07T23:03:45.000-07:00
diff --git a/addon/-private/validate-relationships.js b/addon/-private/validate-relationships.js
@@ -1,4 +1,4 @@
-import { dasherize } from 'json-api-validations/-private/utils/dasherize';
+import { dasherize } from '@ember/string';
 import { RELATIONSHIP_ERROR_TYPES, RelationshipError } from './errors/relationship-error';
 
 export default function validateResourceRelationships(schema, relationships, methodName, path = '') {
diff --git a/addon/-private/validate-resource.js b/addon/-private/validate-resource.js
@@ -1,7 +1,7 @@
-import { dasherize } from 'json-api-validations/-private/utils/dasherize';
+/*
+import { dasherize } from '@ember/string';
 import validateResourceRelationships from './validate-relationships';
 import validateResourceAttributes from './validate-attributes';
-import coalesceAndThrowErrors from './coalesce-errors';
 import { RESOURCE_ERROR_TYPES, ResourceError } from './errors/resource-error';
 
 const _EXPECTED_RESOURCE_KEYS = [
@@ -13,10 +13,22 @@ const _MANDATORY_PRIMARY_RESOURCE_KEYS = [
 const _MANDATORY_SECONDARY_RESOURCE_KEYS = [
   'attributes', 'relationships'
 ];
-
-export default function validateResource(resource, methodName, path) {
-  let errors = [];
-
+*/
+
+/**
+ *
+ * @param validator
+ * @param document
+ * @param issues
+ * @param target
+ * @param path
+ */
+export default function validateResource(/*{ validator, document, issues, target, path }*/) {
+
+  // TODO don't early return;
+  return true;
+
+  /*
   if (!resource) {
     errors.push(new ResourceError(RESOURCE_ERROR_TYPES.RESOURCE_MISSING, undefined, undefined, resource, path));
 
@@ -31,9 +43,10 @@ export default function validateResource(resource, methodName, path) {
     errors = errors.concat(detectTypeErrors(resource, methodName, path));
   }
 
-  coalesceAndThrowErrors(errors);
+  */
 }
 
+/*
 function detectStructuralErrors(payload, methodName, path) {
   let resourceKeys = Object.keys(payload);
   let errors = [];
@@ -104,3 +117,4 @@ function detectTypeErrors(resource, methodName, path) {
 
   return errors;
 }
+*/
diff --git a/tests/unit/invalid-document-test.js b/tests/unit/invalid-document-test.js
@@ -426,11 +426,11 @@ module('Unit | Document', function(hooks) {
       );
     });
 
-    test('MAY contain meta', function(assert) {
-
+    todo('MAY contain meta', function(assert) {
+      assert.notOk('Not Implemented');
     });
-    test('MUST NOT contain other members', function(assert) {
-
+    todo('MUST NOT contain other members', function(assert) {
+      assert.notOk('Not Implemented');
     });
   });
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { dasherize } from 'json-api-validations/-private/utils/dasherize';`
	`1`	`+import { dasherize } from '@ember/string';`
`2`	`2`	`import { RELATIONSHIP_ERROR_TYPES, RelationshipError } from './errors/relationship-error';`
`3`	`3`
`4`	`4`	`export default function validateResourceRelationships(schema, relationships, methodName, path = '') {`