Merge pull request #10967 from ember-cli/copilot/replace-temp-package

NullVoxPopuli · web-flow · commit abe45fe264e9 · 2026-03-24T10:06:03.000-04:00
Replace `temp` package with Node.js built-in `fs.mkdtemp`
diff --git a/lib/commands/test.js b/lib/commands/test.js
@@ -4,16 +4,14 @@ const Command = require('../models/command');
 const Watcher = require('../models/watcher');
 const Builder = require('../models/builder');
 const SilentError = require('silent-error');
+const os = require('os');
 const path = require('path');
 const Win = require('../utilities/windows-admin');
 const fs = require('fs');
-const temp = require('temp');
 const util = require('util');
 const PortFinder = require('portfinder');
 let getPort = util.promisify(PortFinder.getPort);
 
-temp.track();
-
 let defaultPort = 7357;
 
 const ClassicOptions = [
@@ -99,7 +97,7 @@ module.exports = Command.extend({
   },
 
   tmp() {
-    return temp.mkdirSync('tests-dist-');
+    return fs.mkdtempSync(path.join(os.tmpdir(), 'tests-dist-'));
   },
 
   _generateCustomConfigs(options) {
diff --git a/lib/tasks/install-blueprint.js b/lib/tasks/install-blueprint.js
@@ -3,8 +3,7 @@
 const fs = require('fs-extra');
 const Blueprint = require('../models/blueprint');
 const Task = require('../models/task');
-const util = require('util');
-const temp = require('temp');
+const os = require('os');
 const path = require('path');
 const merge = require('lodash/merge');
 const { execa } = require('execa');
@@ -17,11 +16,6 @@ const { isExperimentEnabled } = require('@ember-tooling/blueprint-model/utilitie
 
 const NOT_FOUND_REGEXP = /npm ERR! 404 {2}'(\S+)' is not in the npm registry/;
 
-// Automatically track and cleanup temp files at exit
-temp.track();
-
-let mkdirTemp = util.promisify(temp.mkdir);
-
 class InstallBlueprintTask extends Task {
   async run(options) {
     let cwd = process.cwd();
@@ -115,7 +109,7 @@ class InstallBlueprintTask extends Task {
   }
 
   _createTempFolder() {
-    return mkdirTemp('ember-cli');
+    return fs.mkdtemp(path.join(os.tmpdir(), 'ember-cli-'));
   }
 
   _resolvePackageJSON(directoryPath) {
diff --git a/package.json b/package.json
@@ -128,7 +128,6 @@
     "silent-error": "^1.1.1",
     "sort-package-json": "^3.6.0",
     "symlink-or-copy": "^1.3.1",
-    "temp": "0.9.4",
     "testem": "^3.17.0",
     "tiny-lr": "^2.0.0",
     "tree-sync": "^2.1.0",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tests/integration/utilities/clean-remove-test.js b/tests/integration/utilities/clean-remove-test.js
@@ -2,7 +2,7 @@
 
 const { expect } = require('chai');
 const cleanRemove = require('../../../lib/utilities/clean-remove');
-const temp = require('temp');
+const os = require('os');
 const path = require('path');
 const fs = require('fs-extra');
 
@@ -13,7 +13,7 @@ describe('clean-remove', function () {
   let nestedPath = 'nested1/nested2';
 
   beforeEach(function () {
-    tempDir = temp.mkdirSync('clean-remove');
+    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'clean-remove-'));
     process.chdir(tempDir);
 
     fileInfo = {
diff --git a/tests/unit/utilities/insert-into-file-test.js b/tests/unit/utilities/insert-into-file-test.js
@@ -1,9 +1,9 @@
 'use strict';
 
 const fs = require('fs-extra');
+const os = require('os');
 const path = require('path');
-const temp = require('temp');
-const EOL = require('os').EOL;
+const EOL = os.EOL;
 const insertIntoFile = require('../../../lib/utilities/insert-into-file');
 
 const { expect } = require('chai');
@@ -12,7 +12,7 @@ describe('insertIntoFile()', function () {
   let tempDir, filePath;
 
   beforeEach(function () {
-    tempDir = temp.mkdirSync('insert-into-file-test');
+    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'insert-into-file-test-'));
     filePath = path.join(tempDir, 'foo-bar-baz.txt');
   });
 
