introduce PMD/category/java/codestyle.xml/UnnecessaryConstructor rule

kullfar · kullfar · commit e7dd8e5d3d15 · 2019-04-02T19:44:27.000+03:00
diff --git a/pmd.xml b/pmd.xml
@@ -46,4 +46,5 @@
     <rule ref="category/java/codestyle.xml/NoPackage" />
     <rule ref="category/java/codestyle.xml/PackageCase" />
     <rule ref="category/java/codestyle.xml/UnnecessaryAnnotationValueElement" />
+    <rule ref="category/java/codestyle.xml/UnnecessaryConstructor" />
 </ruleset>
diff --git a/scribejava-apis/src/main/java/com/github/scribejava/apis/NaverApi.java b/scribejava-apis/src/main/java/com/github/scribejava/apis/NaverApi.java
@@ -10,9 +10,6 @@ protected NaverApi() {
 
     private static class InstanceHolder {
         private static final NaverApi INSTANCE = new NaverApi();
-
-        private InstanceHolder() {
-        }
     }
 
     public static NaverApi instance() {
diff --git a/scribejava-core/src/test/java/com/github/scribejava/core/oauth/OAuth20ServiceTest.java b/scribejava-core/src/test/java/com/github/scribejava/core/oauth/OAuth20ServiceTest.java
@@ -121,9 +121,5 @@ public void testOAuthExtractAuthorization() {
     }
 
     private static class TypeTokenImpl extends TypeToken<Map<String, String>> {
-
-        private TypeTokenImpl() {
-        }
     }
-
 }

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,6 @@ protected NaverApi() {`
`10`	`10`
`11`	`11`	`private static class InstanceHolder {`
`12`	`12`	`private static final NaverApi INSTANCE = new NaverApi();`
`13`		`-`
`14`		`- private InstanceHolder() {`
`15`		`- }`
`16`	`13`	`}`
`17`	`14`
`18`	`15`	`public static NaverApi instance() {`
Original file line number	Diff line number	Diff line change
`@@ -121,9 +121,5 @@ public void testOAuthExtractAuthorization() {`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`private static class TypeTokenImpl extends TypeToken<Map<String, String>> {`
`124`		`-`
`125`		`- private TypeTokenImpl() {`
`126`		`- }`
`127`	`124`	`}`
`128`		`-`
`129`	`125`	`}`