discard content buffer for actual line content

implausible · implausible · commit 7a8ac155c9c7 · 2016-01-28T09:49:34.000-07:00
diff --git a/generate/templates/manual/src/convenient_patch.cc b/generate/templates/manual/src/convenient_patch.cc
@@ -78,7 +78,11 @@ PatchData *createFromRaw(git_patch *raw) {
       storeLine->num_lines = line->num_lines;
       storeLine->content_len = line->content_len;
       storeLine->content_offset = line->content_offset;
-      storeLine->content = strdup(line->content);
+      char * transferContent = (char *)malloc(storeLine->content_len + 1);
+      memcpy(transferContent, line->content, storeLine->content_len);
+      transferContent[storeLine->content_len] = '\0';
+      storeLine->content = strdup(transferContent);
+      free((void *)transferContent);
       hunkData->lines->push_back(storeLine);
     }
     patch->hunks->push_back(hunkData);
diff --git a/lib/diff_line.js b/lib/diff_line.js
@@ -2,7 +2,7 @@ var NodeGit = require("../");
 var DiffLine = NodeGit.DiffLine;
 
 /**
-* Pointer to diff text, not NUL-byte terminated
+* The non utf8 translated text
 * @return {String}
 */
 var rawContent = DiffLine.prototype.content;
diff --git a/test/tests/diff.js b/test/tests/diff.js
@@ -133,11 +133,11 @@ describe("Diff", function() {
         assert.equal(patches.length, 3);
         assert(patches[2].isUntracked());
 
-        var oldFile = patches[2].delta.oldFile();
+        var oldFile = patches[2].oldFile();
         assert.equal(oldFile.path(), "wddiff.txt");
         assert.equal(oldFile.size(), 0);
 
-        var newFile = patches[2].delta.newFile();
+        var newFile = patches[2].newFile();
         assert.equal(newFile.path(), "wddiff.txt");
         assert.equal(newFile.size(), 23);
       });
