fix: don't create console window when creating process

codebytere · nornagon · commit f29e6b2849e8 · 2019-02-26T15:24:34.000-08:00
This commit prevents console windows from being spawned when creating processes to better align with what Windows users expect and should be removed when upgrading to a version that includes nodejs/node#21316
diff --git a/deps/uv/src/win/process.c b/deps/uv/src/win/process.c
@@ -1099,6 +1099,9 @@ int uv_spawn(uv_loop_t* loop,
     process_flags |= DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP;
   }
 
+  /* Don't create console window. */
+  process_flags |= CREATE_NO_WINDOW;
+
   if (!CreateProcessW(application_path,
                      arguments,
                      NULL,

Original file line number	Diff line number	Diff line change
`@@ -1099,6 +1099,9 @@ int uv_spawn(uv_loop_t* loop,`
`1099`	`1099`	`process_flags \|= DETACHED_PROCESS \| CREATE_NEW_PROCESS_GROUP;`
`1100`	`1100`	`}`
`1101`	`1101`
	`1102`	`+ /* Don't create console window. */`
	`1103`	`+ process_flags \|= CREATE_NO_WINDOW;`
	`1104`	`+`
`1102`	`1105`	`if (!CreateProcessW(application_path,`
`1103`	`1106`	`arguments,`
`1104`	`1107`	`NULL,`