lib: define FormData and fetch etc. in the built-in snapshot

codebytere · codebytere · commit e7db75b4ce96 · 2024-04-15T11:30:57.000-04:00
nodejs/node#51598
diff --git a/shell/renderer/electron_renderer_client.cc b/shell/renderer/electron_renderer_client.cc
@@ -110,6 +110,10 @@ void ElectronRendererClient::DidCreateScriptContext(
       base::BindRepeating(&ElectronRendererClient::UndeferLoad,
                           base::Unretained(this), render_frame));
 
+  v8::Local<v8::Object> global = renderer_context->Global();
+  v8::Local<v8::String> fetch_string = gin::StringToV8(env->isolate(), "fetch");
+  v8::MaybeLocal<v8::Value> fetch = global->Get(renderer_context, fetch_string);
+
   // If we have disabled the site instance overrides we should prevent loading
   // any non-context aware native module.
   env->options()->force_context_aware = true;
@@ -134,6 +138,16 @@ void ElectronRendererClient::DidCreateScriptContext(
     // Give the node loop a run to make sure everything is ready.
     node_bindings_->StartPolling();
   }
+
+  // We need to use the Blink implementation of fetch in the renderer process
+  // Node.js deletes the global fetch function when their fetch implementation
+  // is disabled, so we need to save and re-add it after the Node.js environment
+  // is loaded.
+  if (!fetch.IsEmpty()) {
+    renderer_context->Global()
+        ->Set(renderer_context, fetch_string, fetch.ToLocalChecked())
+        .Check();
+  }
 }
 
 void ElectronRendererClient::WillReleaseScriptContext(
diff --git a/shell/renderer/web_worker_observer.cc b/shell/renderer/web_worker_observer.cc
@@ -66,12 +66,26 @@ void WebWorkerObserver::WorkerScriptReadyForEvaluation(
   std::shared_ptr<node::Environment> env =
       node_bindings_->CreateEnvironment(worker_context, nullptr);
 
+  v8::Local<v8::Object> global = worker_context->Global();
+  v8::Local<v8::String> fetch_string = gin::StringToV8(env->isolate(), "fetch");
+  v8::MaybeLocal<v8::Value> fetch = global->Get(worker_context, fetch_string);
+
   // Add Electron extended APIs.
   electron_bindings_->BindTo(env->isolate(), env->process_object());
 
   // Load everything.
   node_bindings_->LoadEnvironment(env.get());
 
+  // We need to use the Blink implementation of fetch in WebWorker process
+  // Node.js deletes the global fetch function when their fetch implementation
+  // is disabled, so we need to save and re-add it after the Node.js environment
+  // is loaded.
+  if (!fetch.IsEmpty()) {
+    worker_context->Global()
+        ->Set(worker_context, fetch_string, fetch.ToLocalChecked())
+        .Check();
+  }
+
   // Make uv loop being wrapped by window context.
   node_bindings_->set_uv_env(env.get());
 
