fix: don't call TaskDialogIndirect with disabled parent windows (#50191)

trop[bot] · nmggithub · web-flow · commit ca1b77d9b777 · 2026-03-10T18:05:58.000-07:00
Co-authored-by: trop[bot] &lt;37223003+trop[bot]@users.noreply.github.com&gt;
Co-authored-by: Noah Gregory &lt;noahmgregory@gmail.com&gt;
diff --git a/shell/browser/ui/message_box_win.cc b/shell/browser/ui/message_box_win.cc
@@ -158,7 +158,7 @@ DialogResult ShowTaskDialogWstr(gfx::AcceleratedWidget parent,
   config.hInstance = GetModuleHandle(nullptr);
   config.dwFlags = flags;
 
-  if (parent) {
+  if (parent && ::IsWindowEnabled(parent)) {
     config.hwndParent = parent;
     config.dwFlags |= TDF_POSITION_RELATIVE_TO_WINDOW;
   }

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ DialogResult ShowTaskDialogWstr(gfx::AcceleratedWidget parent,`
`158`	`158`	`config.hInstance = GetModuleHandle(nullptr);`
`159`	`159`	`config.dwFlags = flags;`
`160`	`160`
`161`		`- if (parent) {`
	`161`	`+ if (parent && ::IsWindowEnabled(parent)) {`
`162`	`162`	`config.hwndParent = parent;`
`163`	`163`	`config.dwFlags \|= TDF_POSITION_RELATIVE_TO_WINDOW;`
`164`	`164`	`}`