fix: net.isOnline always true in utility processes (#48152)

trop[bot] · codebytere · web-flow · commit 68e5a3199ba1 · 2025-08-22T11:02:55.000-04:00
* fix: net.isOnline always true in utilityProcesses

Co-authored-by: Shelley Vohr &lt;shelley.vohr@gmail.com&gt;

* Update shell/services/node/node_service.cc

Co-authored-by: Robo &lt;hop2deep@gmail.com&gt;

Co-authored-by: Shelley Vohr &lt;shelley.vohr@gmail.com&gt;

---------

Co-authored-by: trop[bot] &lt;37223003+trop[bot]@users.noreply.github.com&gt;
Co-authored-by: Shelley Vohr &lt;shelley.vohr@gmail.com&gt;
diff --git a/shell/services/node/node_service.cc b/shell/services/node/node_service.cc
@@ -12,6 +12,7 @@
 #include "base/process/process.h"
 #include "base/strings/utf_string_conversions.h"
 #include "electron/mas.h"
+#include "net/base/network_change_notifier.h"
 #include "services/network/public/cpp/wrapper_shared_url_loader_factory.h"
 #include "services/network/public/mojom/host_resolver.mojom.h"
 #include "services/network/public/mojom/network_context.mojom.h"
@@ -126,6 +127,10 @@ void NodeService::Initialize(
 
   node_bindings_->Initialize(js_env_->isolate()->GetCurrentContext());
 
+  network_change_notifier_ = net::NetworkChangeNotifier::CreateIfNeeded(
+      net::NetworkChangeNotifier::CONNECTION_UNKNOWN,
+      net::NetworkChangeNotifier::ConnectionSubtype::SUBTYPE_UNKNOWN);
+
   // Append program path for process.argv0
   auto program = base::CommandLine::ForCurrentProcess()->GetProgram();
 #if defined(OS_WIN)
diff --git a/shell/services/node/node_service.h b/shell/services/node/node_service.h
@@ -11,6 +11,7 @@
 #include "mojo/public/cpp/bindings/pending_remote.h"
 #include "mojo/public/cpp/bindings/receiver.h"
 #include "mojo/public/cpp/bindings/remote.h"
+#include "net/base/network_change_notifier.h"
 #include "services/network/public/cpp/shared_url_loader_factory.h"
 #include "services/network/public/mojom/host_resolver.mojom.h"
 #include "services/network/public/mojom/url_loader_factory.mojom-forward.h"
@@ -84,6 +85,8 @@ class NodeService : public node::mojom::NodeService {
 
   // depends-on: js_env_'s isolate
   std::shared_ptr<node::Environment> node_env_;
+
+  std::unique_ptr<net::NetworkChangeNotifier> network_change_notifier_;
 };
 
 }  // namespace electron
