Skip to content

Commit 5f85b84

Browse files
committed
src: conditionally disable source phase imports by default
nodejs/node#60364
1 parent 9f8bcc4 commit 5f85b84

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

shell/app/node_main.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,10 @@ int NodeMain() {
195195
std::vector<std::string> args = ElectronCommandLine::AsUtf8();
196196
ExitIfContainsDisallowedFlags(args);
197197

198+
// --js-source-phase-imports are not yet enabled in Chromium V8.
199+
// TODO(codebytere): Enable it once V8 enables it.
200+
args.push_back("--no-js-source-phase-imports");
201+
198202
uint64_t process_flags =
199203
node::ProcessInitializationFlags::kNoInitializeV8 |
200204
node::ProcessInitializationFlags::kNoInitializeNodeV8Platform;

shell/common/node_bindings.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -686,6 +686,10 @@ void NodeBindings::Initialize(v8::Isolate* const isolate,
686686
#endif
687687
}
688688

689+
// --js-source-phase-imports are not yet enabled in Chromium V8.
690+
// TODO(codebytere): Enable it once V8 enables it.
691+
args.push_back("--no-js-source-phase-imports");
692+
689693
std::shared_ptr<node::InitializationResult> result =
690694
node::InitializeOncePerProcess(
691695
args,

0 commit comments

Comments
 (0)