src: fix module buffer allocation

codebytere · web-flow · commit 5066736ccc07 · 2025-06-29T10:52:13.000Z
nodejs/node#57738
diff --git a/patches/node/.patches b/patches/node/.patches
@@ -47,3 +47,4 @@ fix_cppgc_initializing_twice.patch
 fix_task_starvation_in_inspector_context_test.patch
 fix_expose_readfilesync_override_for_modules.patch
 chore_remove_protocol_maybe_from_node_string.patch
+fix_-wmismatched-new-delete_in_debug_utils_cc.patch
diff --git a/patches/node/fix_-wmismatched-new-delete_in_debug_utils_cc.patch b/patches/node/fix_-wmismatched-new-delete_in_debug_utils_cc.patch
@@ -0,0 +1,31 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Shelley Vohr <shelley.vohr@gmail.com>
+Date: Thu, 26 Jun 2025 12:46:41 +0000
+Subject: fix: -Wmismatched-new-delete in debug_utils.cc
+
+Fixes the following error:
+
+Error: ../../third_party/electron_node/src/debug_utils.cc(491,11): error: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Werror,-Wmismatched-new-delete]
+  491 |           delete str;
+      |           ^
+      |                 []
+../../third_party/electron_node/src/debug_utils.cc(487,23): note: allocated with 'new[]' here
+  487 |           char* str = new char[size];
+      |                       ^
+1 error generated.
+
+Upstreamed in https://github.com/nodejs/node/pull/58844.
+
+diff --git a/src/debug_utils.cc b/src/debug_utils.cc
+index 97884b9a0f8d6d88e36da06b05642505c767338d..65283ef31da35d0f08fcff7a5e79bf960d861126 100644
+--- a/src/debug_utils.cc
++++ b/src/debug_utils.cc
+@@ -488,7 +488,7 @@ std::vector<std::string> NativeSymbolDebuggingContext::GetLoadedLibraries() {
+           WideCharToMultiByte(
+               CP_UTF8, 0, module_name, -1, str, size, nullptr, nullptr);
+           list.emplace_back(str);
+-          delete str;
++          delete[] str;
+         }
+       }
+     }
