Skip to content

Commit 2319577

Browse files
committed
deps: use nghttp2's config.h on all platforms
nodejs/node#27283
1 parent 542cce6 commit 2319577

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

patches/node/build_add_gn_build_files.patch

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -709,10 +709,10 @@ index 0000000000000000000000000000000000000000..fb000f8ee7647c375bc190d1729d67bb
709709
+}
710710
diff --git a/deps/nghttp2/BUILD.gn b/deps/nghttp2/BUILD.gn
711711
new file mode 100644
712-
index 0000000000000000000000000000000000000000..8bfecba74d4d90e9fbf0e2cd301118e4adc6cba8
712+
index 0000000000000000000000000000000000000000..25589ebecd9648e9a9fbb126be98d5b315fa60b2
713713
--- /dev/null
714714
+++ b/deps/nghttp2/BUILD.gn
715-
@@ -0,0 +1,49 @@
715+
@@ -0,0 +1,53 @@
716716
+config("nghttp2_config") {
717717
+ defines = [ "NGHTTP2_STATICLIB" ]
718718
+ include_dirs = [ "lib/includes" ]
@@ -723,10 +723,14 @@ index 0000000000000000000000000000000000000000..8bfecba74d4d90e9fbf0e2cd301118e4
723723
+ "_U_",
724724
+ "BUILDING_NGHTTP2",
725725
+ "NGHTTP2_STATICLIB",
726+
+ "HAVE_CONFIG_H",
726727
+ ]
727728
+ include_dirs = [ "lib/includes" ]
728729
+ if (is_win) {
729-
+ defines += [ "HAVE_CONFIG_H" ]
730+
+ defines += [
731+
+ "WIN32",
732+
+ "_WINDOWS"
733+
+ ]
730734
+ }
731735
+
732736
+ cflags_c = [

patches/node/chore_fix_-wimplicit-fallthrough.patch

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ Subject: chore: fix -Wimplicit-fallthrough
66
Upstreamed at https://github.com/nghttp2/nghttp2/pull/1626.
77

88
diff --git a/deps/nghttp2/BUILD.gn b/deps/nghttp2/BUILD.gn
9-
index 8bfecba74d4d90e9fbf0e2cd301118e4adc6cba8..63e1149f0c4a39cb944114e5824d6074343301e8 100644
9+
index 25589ebecd9648e9a9fbb126be98d5b315fa60b2..3760f6769e2dae2e5f0bba32609034e4453ff89a 100644
1010
--- a/deps/nghttp2/BUILD.gn
1111
+++ b/deps/nghttp2/BUILD.gn
12-
@@ -16,7 +16,6 @@ static_library("nghttp2") {
12+
@@ -20,7 +20,6 @@ static_library("nghttp2") {
1313

1414
cflags_c = [
1515
"-Wno-implicit-function-declaration",

0 commit comments

Comments
 (0)