Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: miguelgrinberg/python-socketio
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: eduflow/python-socketio
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 3 files changed
  • 3 contributors

Commits on Nov 27, 2018

  1. 👽 Make message format conform with Node.js socketio

    @jamieconnelly @flacerdk
    jamieconnelly authored and flacerdk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    9d4d8c3 View commit details
    Browse the repository at this point in the history

  2. ♻️ Update _handle_emit to conform to node socketio format

    @jamieconnelly @flacerdk
    jamieconnelly authored and flacerdk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    2906bd5 View commit details
    Browse the repository at this point in the history

  3. 🔥 PubSub: remove unreached method calls

    @jamieconnelly @flacerdk
    jamieconnelly authored and flacerdk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    4898304 View commit details
    Browse the repository at this point in the history

  4. 👽 use psubcribe instead of subscribe

    @jamieconnelly @flacerdk
    jamieconnelly authored and flacerdk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    32228c8 View commit details
    Browse the repository at this point in the history

  5. setup.py: Add msgpack dependency

    @malthejorgensen @flacerdk
    malthejorgensen authored and flacerdk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    4da86c1 View commit details
    Browse the repository at this point in the history

  6. ♿ Python 3.x msgpack encoding support 

    use_bin_type=True (This is the future 1.0 default) in
msgpack.packb (Packer)

And raw=False (Future 1.0 default) in msgpack.unpackb (Unpacker)

This will ensure serialization doesn't unpickle keys, e.g. 'data'
as b'data', causing a KeyError in def _thread.

See also: https://github.com/msgpack/msgpack-python
    @tony @flacerdk
    tony authored and flacerdk committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    d575ec2 View commit details
    Browse the repository at this point in the history
Loading