Ensure access to autoRefresh is thread-safe

msohn · msohn · commit 4ef88700db1d · 2025-03-03T22:17:30.000+01:00
Change-Id: I7651613c33803daf00882a543dbf0c3f836110fa
diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileReftableDatabase.java
@@ -24,6 +24,7 @@
 import java.util.Map;
 import java.util.Set;
 import java.util.TreeSet;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
 import java.util.stream.Collectors;
@@ -72,7 +73,7 @@ public class FileReftableDatabase extends RefDatabase {
 
 	private final FileReftableStack reftableStack;
 
-	private boolean autoRefresh;
+	private final AtomicBoolean autoRefresh;
 
 	FileReftableDatabase(FileRepository repo) throws IOException {
 		this(repo, new File(new File(repo.getCommonDirectory(), Constants.REFTABLE),
@@ -81,9 +82,9 @@ public class FileReftableDatabase extends RefDatabase {
 
 	FileReftableDatabase(FileRepository repo, File refstackName) throws IOException {
 		this.fileRepository = repo;
-		this.autoRefresh = repo.getConfig().getBoolean(
+		this.autoRefresh = new AtomicBoolean(repo.getConfig().getBoolean(
 				ConfigConstants.CONFIG_REFTABLE_SECTION,
-				ConfigConstants.CONFIG_KEY_AUTOREFRESH, false);
+				ConfigConstants.CONFIG_KEY_AUTOREFRESH, false));
 		this.reftableStack = new FileReftableStack(refstackName,
 				new File(fileRepository.getCommonDirectory(), Constants.REFTABLE),
 			() -> fileRepository.fireEvent(new RefsChangedEvent()),
@@ -241,7 +242,7 @@ public Ref peel(Ref ref) throws IOException {
 	 *            date.
 	 */
 	public void setAutoRefresh(boolean autoRefresh) {
-		this.autoRefresh = autoRefresh;
+		this.autoRefresh.set(autoRefresh);
 	}
 
 	/**
@@ -251,11 +252,11 @@ public void setAutoRefresh(boolean autoRefresh) {
 	 *         date.
 	 */
 	public boolean isAutoRefresh() {
-		return autoRefresh;
+		return autoRefresh.get();
 	}
 
 	private void autoRefresh() {
-		if (autoRefresh) {
+		if (autoRefresh.get()) {
 			refresh();
 		}
 	}
