Repository navigation
Improve the performance of inferSelection - #1609
Merged
testforstephen merged 1 commit intoNov 27, 2020
Merged
Conversation
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
add to whitelist |
Contributor
Contributor
Contributor
|
test this please |
testforstephen
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the language server is just finding valid expression,
ExtractMethodRefactoring.checkInitialConditions()has no need to do some initialize methods, in some corner cases such as working on a large Java file with many duplicate methods, this may affect the performance ofinferSelection.This PR is to remove the unnecessary processes.
Signed-off-by: Shi Chen chenshi@microsoft.com