Fix server create with nova-net

Dean Troyer · Dean Troyer · commit bffc98e4e526 · 2017-04-26T18:49:50.000-05:00
A Neutron-ism slipped by in server create.

Change-Id: Id590d7f93df2a41d7bd7617459a2af159a6f8071
diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py
@@ -655,10 +655,9 @@ def take_action(self, parsed_args):
                         nic_info["port-id"] = port.id
                 else:
                     if nic_info["net-id"]:
-                        nic_info["net-id"] = utils.find_resource(
-                            compute_client.networks,
+                        nic_info["net-id"] = compute_client.api.network_find(
                             nic_info["net-id"]
-                        ).id
+                        )['id']
                     if nic_info["port-id"]:
                         msg = _("can't create server with port specified "
                                 "since network endpoint not enabled")
diff --git a/openstackclient/tests/functional/compute/v2/test_server.py b/openstackclient/tests/functional/compute/v2/test_server.py
@@ -207,12 +207,20 @@ def test_server_attach_detach_floating_ip(self):
             'floating ip create -f json ' +
             'public'
         ))
-        floating_ip = cmd_output['floating_ip_address']
+
+        # Look for Neutron value first, then nova-net
+        floating_ip = cmd_output.get(
+            'floating_ip_address',
+            cmd_output.get(
+                'ip',
+                None,
+            ),
+        )
         self.assertNotEqual('', cmd_output['id'])
         self.assertNotEqual('', floating_ip)
         self.addCleanup(
             self.openstack,
-            'floating ip delete ' + cmd_output['id']
+            'floating ip delete ' + str(cmd_output['id'])
         )
 
         raw_output = self.openstack(
