Pull request that added support for CASE WHEN broke Postgres.visitColumn when column implicitly aliased is used in CASE. Pull request to better support js property to column-name mapping broke AS aliasing during Postgres.visitReturning.

paul-tfr · paul-tfr · commit 60da34954097 · 2013-12-23T18:22:00.000-07:00
This change fixes both issues.
diff --git a/test/column-tests.js b/test/column-tests.js
@@ -114,6 +114,14 @@ describe('column', function() {
       it('but not when with explicit property name', function() {
         assert.equal(table.not2Cam.toQuery().text, '"sc"."not_to_camel" AS "not2Cam"');
       });
-    })
+      it('does not use property alias within CASE ... END', function() {
+        assert.equal(table.makeMeCamel.case([table.makeMeCamel.equals(0)],[table.makeMeCamel]).as('rename').toQuery().text,
+          '(CASE WHEN ("sc"."make_me_camel" = $1) THEN "sc"."make_me_camel" END) AS "rename"');
+      });
+      it('respects AS rename in RETURNING clause', function() {
+        assert.equal(table.update({makeMeCamel:0}).returning(table.makeMeCamel.as('rename')).toQuery().text,
+          'UPDATE "sc" SET "make_me_camel" = $1 RETURNING "sc"."make_me_camel" AS "rename"');
+      });
+    });
   });
 });
