Fixed warning

ankane · ankane · commit 1987708e1dae · 2022-11-13T16:44:03.000-08:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -20,5 +20,5 @@ jobs:
         CXXFLAGS=-std=c++17 ./configure
         make
         sudo make install
-    - run: g++ -std=c++17 -o test/pqxx test/pqxx_test.cpp -lpqxx -lpq
+    - run: g++ -std=c++17 -Wall -Wextra -Werror -o test/pqxx test/pqxx_test.cpp -lpqxx -lpq
     - run: test/pqxx
diff --git a/README.md b/README.md
@@ -72,6 +72,6 @@ To get started with development:
 git clone https://github.com/pgvector/pgvector-cpp.git
 cd pgvector-cpp
 createdb pgvector_cpp_test
-g++ -std=c++17 -o test/pqxx test/pqxx_test.cpp -lpqxx -lpq
+g++ -std=c++17 -Wall -Wextra -Werror -o test/pqxx test/pqxx_test.cpp -lpqxx -lpq
 test/pqxx
 ```
diff --git a/include/vector.hpp b/include/vector.hpp
@@ -30,7 +30,7 @@ class Vector {
 
   friend std::ostream &operator<<(std::ostream &os, const Vector &value) {
     os << "[";
-    for (auto i = 0; i < value.value_.size(); i++) {
+    for (size_t i = 0; i < value.value_.size(); i++) {
       if (i > 0) {
         os << ",";
       }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class Vector {`
`30`	`30`
`31`	`31`	`friend std::ostream &operator<<(std::ostream &os, const Vector &value) {`
`32`	`32`	`os << "[";`
`33`		`- for (auto i = 0; i < value.value_.size(); i++) {`
	`33`	`+ for (size_t i = 0; i < value.value_.size(); i++) {`
`34`	`34`	`if (i > 0) {`
`35`	`35`	`os << ",";`
`36`	`36`	`}`