Test with libpqxx 7.8

ankane · ankane · commit 07168e7a9999 · 2023-08-31T18:49:18.000-07:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -16,7 +16,7 @@ jobs:
           make
           sudo make install
       - run: |
-          git clone --branch 7.7.5 https://github.com/jtv/libpqxx.git
+          git clone --branch 7.8.1 https://github.com/jtv/libpqxx.git
           cd libpqxx
           CXXFLAGS=-std=c++17 ./configure
           make
diff --git a/test/pqxx_test.cpp b/test/pqxx_test.cpp
@@ -31,12 +31,9 @@ void test_works(pqxx::connection &conn) {
 
 void test_stream(pqxx::connection &conn) {
   pqxx::work txn{conn};
-  auto stream = pqxx::stream_from::query(txn, "SELECT id, embedding FROM items WHERE embedding IS NOT NULL");
-  std::tuple<int, pgvector::Vector> row;
-  while (stream >> row) {
-    assert(std::get<1>(row).dimensions() == 3);
+  for (auto [id, embedding] : txn.stream<int, pgvector::Vector>("SELECT id, embedding FROM items WHERE embedding IS NOT NULL")) {
+    assert(embedding.dimensions() == 3);
   }
-  stream.complete();
   txn.commit();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -31,12 +31,9 @@ void test_works(pqxx::connection &conn) {`
`31`	`31`
`32`	`32`	`void test_stream(pqxx::connection &conn) {`
`33`	`33`	`pqxx::work txn{conn};`
`34`		`- auto stream = pqxx::stream_from::query(txn, "SELECT id, embedding FROM items WHERE embedding IS NOT NULL");`
`35`		`- std::tuple<int, pgvector::Vector> row;`
`36`		`- while (stream >> row) {`
`37`		`- assert(std::get<1>(row).dimensions() == 3);`
	`34`	`+ for (auto [id, embedding] : txn.stream<int, pgvector::Vector>("SELECT id, embedding FROM items WHERE embedding IS NOT NULL")) {`
	`35`	`+ assert(embedding.dimensions() == 3);`
`38`	`36`	`}`
`39`		`- stream.complete();`
`40`	`37`	`txn.commit();`
`41`	`38`	`}`
`42`	`39`