https-proxy-agent: create the proxy socket connection first

TooTallNate · TooTallNate · commit e5ecd0b04622 · 2013-11-16T12:55:20.000-08:00
Also remove the `host`, `hostname`, and `port` opts from the proxy
opts before mixing in. Shouldn't strictly be necessary, but gives me
a little bit of piece of mind.

Also add comment reminding me about why we mix in the proxy options,
since coming back today I had to think about it for a while before
remembering why it was necessary (good thing I have tests for it!)
diff --git a/https-proxy-agent.js b/https-proxy-agent.js
@@ -74,16 +74,23 @@ function connect (req, _opts, fn) {
   var secureProxy = this.secureProxy;
   var secureEndpoint = this.secureEndpoint;
 
-  // these `opts` are the connect options to connect to the destination endpoint
-  var opts = extend({}, proxy, secureEndpoint ? secureDefaults : defaults, _opts);
-
+  // create a socket connection to the proxy server
   var socket;
   if (secureProxy) {
     socket = tls.connect(proxy);
   } else {
     socket = net.connect(proxy);
   }
 
+  // these `opts` are the connect options to connect to the destination endpoint
+  // XXX: we mix in the proxy options so that TLS options like
+  // `rejectUnauthorized` get passed to the destination endpoint as well
+  var proxyOpts = extend({}, proxy);
+  delete proxyOpts.host;
+  delete proxyOpts.hostname;
+  delete proxyOpts.port;
+  var opts = extend({}, proxyOpts, secureEndpoint ? secureDefaults : defaults, _opts);
+
   // we need to buffer any HTTP traffic that happens with the proxy before we get
   // the CONNECT response, so that if the response is anything other than an "200"
   // response code, then we can re-play the "data" events on the socket once the
