add checkstyle rules, fix UnnecessaryParentheses

s-gromov · s-gromov · commit c1fda9863504 · 2016-01-25T13:55:29.000+03:00
diff --git a/checkstyle.xml b/checkstyle.xml
@@ -44,5 +44,15 @@
         </module>
         <module name="InnerAssignment"/>
         <module name="MissingSwitchDefault"/>
+        <module name="MultipleVariableDeclarations"/>
+        <module name="NoClone"/>
+        <module name="NoFinalizer"/>
+        <module name="OneStatementPerLine"/>
+        <module name="OverloadMethodsDeclarationOrder"/>
+        <module name="PackageDeclaration"/>
+        <module name="SimplifyBooleanExpression"/>
+        <module name="SimplifyBooleanReturn"/>
+        <module name="StringLiteralEquality"/>
+        <module name="UnnecessaryParentheses"/>
     </module>
 </module>
diff --git a/scribejava-apis/src/main/java/com/github/scribejava/apis/service/OdnoklassnikiServiceImpl.java b/scribejava-apis/src/main/java/com/github/scribejava/apis/service/OdnoklassnikiServiceImpl.java
@@ -20,7 +20,7 @@ public OdnoklassnikiServiceImpl(DefaultApi20 api, OAuthConfig config) {
     public void signRequest(Token accessToken, AbstractRequest request) {
         // sig = md5( request_params_composed_string+ md5(access_token + application_secret_key)  )
         try {
-            final String tokenDigest = md5Hex((accessToken.getToken() + getConfig().getApiSecret()));
+            final String tokenDigest = md5Hex(accessToken.getToken() + getConfig().getApiSecret());
 
             final String completeUrl = request.getCompleteUrl();
             final int queryIndex = completeUrl.indexOf('?');
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuthService.java b/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuthService.java
@@ -35,7 +35,7 @@ public OAuthService(OAuthConfig config) {
             if (ForceTypeOfHttpRequest.PREFER_SYNC_ONLY_HTTP_REQUESTS == forceTypeOfHttpRequest) {
                 config.log("Cannot use async operations, only sync");
             }
-            final OAuthConfigAsync asyncConfig = ((OAuthConfigAsync) config);
+            final OAuthConfigAsync asyncConfig = (OAuthConfigAsync) config;
             final String asyncHttpProviderClassName = asyncConfig.getAsyncHttpProviderClassName();
 
             asyncHttpClient = asyncHttpProviderClassName == null ? new AsyncHttpClient(asyncConfig.getAsyncHttpClientConfig())

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public OAuthService(OAuthConfig config) {`
`35`	`35`	`if (ForceTypeOfHttpRequest.PREFER_SYNC_ONLY_HTTP_REQUESTS == forceTypeOfHttpRequest) {`
`36`	`36`	`config.log("Cannot use async operations, only sync");`
`37`	`37`	`}`
`38`		`- final OAuthConfigAsync asyncConfig = ((OAuthConfigAsync) config);`
	`38`	`+ final OAuthConfigAsync asyncConfig = (OAuthConfigAsync) config;`
`39`	`39`	`final String asyncHttpProviderClassName = asyncConfig.getAsyncHttpProviderClassName();`
`40`	`40`
`41`	`41`	`asyncHttpClient = asyncHttpProviderClassName == null ? new AsyncHttpClient(asyncConfig.getAsyncHttpClientConfig())`