Skip to content

Commit e744e60

Browse files
TerryHoweTerry Howe
authored andcommitted
Change example so CLI names match object arguments
I would like to extract the arguments automatically from the example command line arguments. If the names matched, it would be much easier. Change-Id: I0877fe8a0b6f5a61505fdecddd2f72ee8c505d29
1 parent 5bc607e commit e744e60

File tree

4 files changed

+32
-21
lines changed

4 files changed

+32
-21
lines changed

examples/authenticate.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ def get_endpoint(self, transport, service, **kwargs):
4848

4949
def make_authenticate(opts):
5050
return authenticator.create(
51-
username=opts.os_username,
52-
password=opts.os_password,
53-
token=opts.os_token,
54-
auth_url=opts.os_auth_url,
55-
version=opts.os_identity_api_version,
56-
project_name=opts.os_project_name,
57-
domain_name=opts.os_domain_name,
58-
project_domain_name=opts.os_project_domain_name,
59-
user_domain_name=opts.os_user_domain_name,
51+
username=opts.username,
52+
password=opts.password,
53+
token=opts.token,
54+
auth_url=opts.auth_url,
55+
version=opts.identity_api_version,
56+
project_name=opts.project_name,
57+
domain_name=opts.domain_name,
58+
project_domain_name=opts.project_domain_name,
59+
user_domain_name=opts.user_domain_name,
6060
)
6161

6262

examples/common.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,57 +118,66 @@ def option_parser():
118118
# Global arguments
119119
parser.add_argument(
120120
'--os-auth-url',
121+
dest='auth_url',
121122
metavar='<auth-url>',
122123
default=env('OS_AUTH_URL'),
123124
help='Authentication URL (Env: OS_AUTH_URL)',
124125
)
125126
parser.add_argument(
126127
'--os-project-name',
128+
dest='project_name',
127129
metavar='<auth-project-name>',
128130
default=env('OS_PROJECT_NAME', default=env('OS_TENANT_NAME')),
129131
help='Project name of the requested project-level'
130132
'authorization scope (Env: OS_PROJECT_NAME)',
131133
)
132134
parser.add_argument(
133135
'--os-domain-name',
136+
dest='domain_name',
134137
metavar='<auth-domain-name>',
135138
default=env('OS_DOMAIN_NAME'),
136139
help='Domain name for scope of '
137140
'authorization (Env: OS_DOMAIN_NAME)',
138141
)
139142
parser.add_argument(
140143
'--os-project-domain-name',
144+
dest='project_domain_name',
141145
metavar='<auth-project-domain-name>',
142146
default=env('OS_PROJECT_DOMAIN_NAME'),
143147
help='Project domain name for scope of '
144148
'authorization (Env: OS_PROJECT_DOMAIN_NAME)',
145149
)
146150
parser.add_argument(
147151
'--os-user-domain-name',
152+
dest='user_domain_name',
148153
metavar='<auth-user-domain-name>',
149154
default=env('OS_USER_DOMAIN_NAME'),
150155
help='User domain name for scope of '
151156
'authorization (Env: OS_USER_DOMAIN_NAME)',
152157
)
153158
parser.add_argument(
154159
'--os-username',
160+
dest='username',
155161
metavar='<auth-username>',
156162
default=env('OS_USERNAME'),
157163
help='Authentication username (Env: OS_USERNAME)',
158164
)
159165
parser.add_argument(
160166
'--os-password',
167+
dest='password',
161168
metavar='<auth-password>',
162169
default=env('OS_PASSWORD'),
163170
help='Authentication password (Env: OS_PASSWORD)',
164171
)
165172
parser.add_argument(
166173
'--os-region-name',
174+
dest='region_name',
167175
metavar='<region>',
168176
default=env('OS_REGION_NAME'),
169177
help='Service region (Env: OS_REGION_NAME)')
170178
parser.add_argument(
171179
'--os-cacert',
180+
dest='cacert',
172181
metavar='<ca-bundle-file>',
173182
default=env('OS_CACERT'),
174183
help='CA certificate bundle file (Env: OS_CACERT)',
@@ -186,6 +195,7 @@ def option_parser():
186195
)
187196
parser.add_argument(
188197
'--os-identity-api-version',
198+
dest='identity_api_version',
189199
metavar='<identity-api-version>',
190200
default=env(
191201
'OS_IDENTITY_API_VERSION',
@@ -194,6 +204,7 @@ def option_parser():
194204
)
195205
parser.add_argument(
196206
'--os-token',
207+
dest='token',
197208
metavar='<token>',
198209
default=env('OS_TOKEN'),
199210
help='Defaults to env[OS_TOKEN]',

examples/session.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,19 @@
2929

3030
def make_session(opts):
3131
return session.Session.create(
32-
username=opts.os_username,
33-
password=opts.os_password,
34-
token=opts.os_token,
35-
auth_url=opts.os_auth_url,
36-
version=opts.os_identity_api_version,
37-
project_name=opts.os_project_name,
38-
domain_name=opts.os_domain_name,
39-
project_domain_name=opts.os_project_domain_name,
40-
user_domain_name=opts.os_user_domain_name,
41-
cacert=opts.os_cacert,
32+
username=opts.username,
33+
password=opts.password,
34+
token=opts.token,
35+
auth_url=opts.auth_url,
36+
version=opts.identity_api_version,
37+
project_name=opts.project_name,
38+
domain_name=opts.domain_name,
39+
project_domain_name=opts.project_domain_name,
40+
user_domain_name=opts.user_domain_name,
41+
cacert=opts.cacert,
4242
insecure=opts.insecure,
4343
user_agent='SDKExample',
44-
region=opts.os_region_name,
44+
region=opts.region_name,
4545
)
4646

4747

examples/transport.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
def make_transport(opts):
3333
return transport.Transport.create(
34-
cacert=opts.os_cacert,
34+
cacert=opts.cacert,
3535
insecure=opts.insecure,
3636
user_agent=USER_AGENT
3737
)

0 commit comments

Comments
 (0)