Skip to content

"wait for target" uses the selector, not the target #97

Open

Description

@lawik

This means that it also skips any parent targets defined for that target.

This increases the risk of false positives a fair bit. For us it lead to a very ugly bug for us where a specific xpath target would do the expected thing but a CSS target would hit widely on the page by ignoring its parent and pass when it shouldn't.

Activity

  1. lawik commented on Jun 28, 2021

    @lawik
    ContributorAuthor

    Found the NOTE in the description while digging around the implementation. Realized that it is noted in the UI too. Not particularly clear for this use-case though and makes using chained targets/parents pretty much a footgun.

    NOTE: This method is ignored by chained targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions