Skip to content

Commit 4f4cf2a

Browse files
author
Douglas Greiman
authored
Skip tests that hit known bug in Python pre-3.4.4 interpreters. (googleapis#4271)
1 parent f383b8c commit 4f4cf2a

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

firestore/tests/unit/test__helpers.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
import collections
1616
import datetime
17+
import sys
1718
import unittest
1819

1920
import mock
@@ -673,6 +674,8 @@ def test_float(self):
673674
value = _value_pb(double_value=float_val)
674675
self.assertEqual(self._call_fut(value), float_val)
675676

677+
@unittest.skipIf((3,) <= sys.version_info < (3,4,4),
678+
'known datetime bug (bpo-23517) in Python')
676679
def test_datetime(self):
677680
from google.protobuf import timestamp_pb2
678681
from google.cloud._helpers import UTC
@@ -811,6 +814,8 @@ def _call_fut(value_fields, client=mock.sentinel.client):
811814

812815
return decode_dict(value_fields, client)
813816

817+
@unittest.skipIf((3,) <= sys.version_info < (3,4,4),
818+
'known datetime bug (bpo-23517) in Python')
814819
def test_many_types(self):
815820
from google.protobuf import struct_pb2
816821
from google.protobuf import timestamp_pb2

0 commit comments

Comments
 (0)