Skip to content

Commit eeb2632

Browse files
Switch function definition hash to NodeDef, fixing a TODO.
Change: 139963371
1 parent 6e45225 commit eeb2632

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

tensorflow/python/framework/function.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -654,12 +654,10 @@ def update_strs(slist):
654654
for s in slist:
655655
update_str(s)
656656

657-
# TODO(josh11b): Switch .node to .node_def
658-
for n in sorted(self._definition.node, key=lambda n: n.ret[0]):
659-
update_strs(n.ret)
657+
for n in sorted(self._definition.node_def, key=lambda n: n.name):
658+
update_str(n.name)
660659
update_str(n.op)
661-
update_strs(n.arg)
662-
update_strs(n.dep)
660+
update_strs(n.input)
663661
update_num(len(n.attr))
664662
# NOTE: protobuf map serialization does not guarantee ordering.
665663
for k in sorted(n.attr):

tensorflow/python/framework/function_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ def testStableName(self):
566566
def Foo(x, y, z):
567567
return tf.tanh(tf.matmul(x, y) + z)
568568

569-
self.assertEqual("Foo_158cce4d", Foo.instantiate([tf.float32] * 3).name)
569+
self.assertEqual("Foo_e0cb6030", Foo.instantiate([tf.float32] * 3).name)
570570

571571

572572
class FunctionOverloadTest(tf.test.TestCase):

0 commit comments

Comments
 (0)