further perf optimization: do not create integer objects at all

shotwave · shotwave · commit 0d2b068092fc · 2011-05-25T15:54:59.000Z
diff --git a/src/difflib/DeltaComparator.java b/src/difflib/DeltaComparator.java
@@ -14,6 +14,13 @@ private DeltaComparator() {
     }
 
     public int compare(final Delta a, final Delta b) {
-        return Integer.valueOf(a.getOriginal().getPosition()).compareTo(b.getOriginal().getPosition());
+        final int posA = a.getOriginal().getPosition();
+        final int posB = b.getOriginal().getPosition();
+        if (posA > posB) {
+            return 1;
+        } else if (posA < posB) {
+            return -1;
+        }
+        return 0;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,13 @@ private DeltaComparator() {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`public int compare(final Delta a, final Delta b) {`
`17`		`- return Integer.valueOf(a.getOriginal().getPosition()).compareTo(b.getOriginal().getPosition());`
	`17`	`+ final int posA = a.getOriginal().getPosition();`
	`18`	`+ final int posB = b.getOriginal().getPosition();`
	`19`	`+ if (posA > posB) {`
	`20`	`+ return 1;`
	`21`	`+ } else if (posA < posB) {`
	`22`	`+ return -1;`
	`23`	`+ }`
	`24`	`+ return 0;`
`18`	`25`	`}`
`19`	`26`	`}`