fix: added types to exec & tc_properties_get_tc_host (testcontainers#561)

Dandiggas · web-flow · commit 9eabb79f213c · 2024-05-17T05:13:51.000-05:00
testcontainers#557 - trying to solve this issue by adding types. --------- Co-authored-by: Dandiggas <dadekugbe@googlemail.com>
diff --git a/core/testcontainers/core/config.py b/core/testcontainers/core/config.py
@@ -2,6 +2,7 @@
 from os import environ
 from os.path import exists
 from pathlib import Path
+from typing import Union
 
 MAX_TRIES = int(environ.get("TC_MAX_TRIES", 120))
 SLEEP_TIME = int(environ.get("TC_POOLING_INTERVAL", 1))
@@ -47,7 +48,7 @@ class TestcontainersConfiguration:
     ryuk_reconnection_timeout: str = RYUK_RECONNECTION_TIMEOUT
     tc_properties: dict[str, str] = field(default_factory=read_tc_properties)
 
-    def tc_properties_get_tc_host(self):
+    def tc_properties_get_tc_host(self) -> Union[str, None]:
         return self.tc_properties.get("tc.host")
 
     @property
diff --git a/core/testcontainers/core/container.py b/core/testcontainers/core/container.py
@@ -172,7 +172,7 @@ def get_logs(self) -> tuple[bytes, bytes]:
             raise ContainerStartException("Container should be started before getting logs")
         return self._container.logs(stderr=False), self._container.logs(stdout=False)
 
-    def exec(self, command) -> tuple[int, str]:
+    def exec(self, command) -> tuple[int, bytes]:
         if not self._container:
             raise ContainerStartException("Container should be started before executing a command")
         return self._container.exec_run(command)
