Skip to content

Commit b9b6856

Browse files
committed
Fix duplicate class names
1 parent 74c5821 commit b9b6856

5 files changed

Lines changed: 33 additions & 4 deletions

File tree

‎TODOS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Todo
22

33
## Bugs
4+
* autoc|() should'nt add an extra () before the existing one
45
* import static org.| doesn't auto-complete
56
* array.length doesn't auto-complete
67
* Hover doesn't show 'throws ...'

‎src/main/java/org/javacs/Completions.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,9 @@ private Stream<CompletionItem> notImportedClasses(String partialIdentifier, Scop
384384
Stream<String> fromSourcePath =
385385
accessibleSourcePathClasses(partialIdentifier, scope).map(c -> c.qualifiedName());
386386
Stream<String> fromClassPath =
387-
accessibleClassPathClasses(partialIdentifier, scope).map(c -> c.getName());
388-
// TODO remove class path classes that are also available from source path
387+
accessibleClassPathClasses(partialIdentifier, scope)
388+
.map(c -> c.getName())
389+
.filter(name -> !sourcePath.isTopLevelClass(name));
389390

390391
return Stream.concat(fromSourcePath, fromClassPath)
391392
.map(this::completeClassNameFromClassPath);

‎src/main/java/org/javacs/SymbolIndex.java‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,10 @@ private String packageName() {
247247
}
248248
}
249249

250+
boolean isTopLevelClass(String qualifiedName) {
251+
return doFindDeclaringFile(qualifiedName).isPresent();
252+
}
253+
250254
Stream<ReachableClass> accessibleTopLevelClasses(String fromPackage) {
251255
finishedInitialIndex.join();
252256

@@ -270,8 +274,13 @@ Stream<ReachableClass> allTopLevelClasses() {
270274
Optional<URI> findDeclaringFile(TypeElement topLevelClass) {
271275
updateOpenFiles();
272276

273-
String qualifiedName = topLevelClass.getQualifiedName().toString(),
274-
packageName = Completions.mostIds(qualifiedName),
277+
String qualifiedName = topLevelClass.getQualifiedName().toString();
278+
279+
return doFindDeclaringFile(qualifiedName);
280+
}
281+
282+
private Optional<URI> doFindDeclaringFile(String qualifiedName) {
283+
String packageName = Completions.mostIds(qualifiedName),
275284
className = Completions.lastId(qualifiedName);
276285
Predicate<Map.Entry<URI, SourceFileIndex>> containsClass =
277286
entry -> {

‎src/test/java/org/javacs/CompletionsTest.java‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import java.io.IOException;
88
import java.net.URLClassLoader;
99
import java.util.List;
10+
import java.util.Map;
1011
import java.util.Set;
1112
import java.util.stream.Collectors;
1213
import org.eclipse.lsp4j.CompletionItem;
@@ -746,4 +747,14 @@ public void withinConstructor() throws IOException {
746747

747748
assertThat("suggests local variable", suggestions, hasItems("length"));
748749
}
750+
751+
@Test
752+
public void onlySuggestOnce() throws IOException {
753+
String file = "/org/javacs/example/AutocompleteOnce.java";
754+
755+
Map<String, Integer> suggestions = insertCount(file, 5, 18);
756+
757+
assertThat("suggests Signatures", suggestions, hasKey("Signatures"));
758+
assertThat("suggests Signatures only once", suggestions, hasEntry("Signatures", 1));
759+
}
749760
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package org.javacs.example;
2+
3+
public class AutocompleteOnce {
4+
public void test() {
5+
Signature
6+
}
7+
}

0 commit comments

Comments
 (0)