tests: refactor system tests

parthea · parthea · commit 6e08d1f1757b · 2026-03-03T21:38:39.000Z
diff --git a/.kokoro/system.sh b/.kokoro/system.sh
@@ -51,6 +51,12 @@ run_package_test() {
 
   case "${package_name}" in
     "google-auth")
+      # Copy files needed for google-auth system tests
+      mkdir -p "${package_path}/system_tests/data"
+      cp "${KOKORO_GFILE_DIR}/google-auth-service-account.json" "${package_path}/system_tests/data/service_account.json"
+      cp "${KOKORO_GFILE_DIR}/google-auth-authorized-user.json" "${package_path}/system_tests/data/authorized_user.json"
+      cp "${KOKORO_GFILE_DIR}/google-auth-impersonated-service-account.json" "${package_path}/system_tests/data/impersonated_service_account.json"
+
       PROJECT_ID=$(cat "${KOKORO_GFILE_DIR}/google-auth-project-id.json")
       GOOGLE_APPLICATION_CREDENTIALS="${KOKORO_GFILE_DIR}/google-auth-service-account.json"
       NOX_FILE="system_tests/noxfile.py"
diff --git a/packages/google-auth/system_tests/noxfile.py b/packages/google-auth/system_tests/noxfile.py
@@ -25,7 +25,6 @@
 import os
 import pathlib
 import shutil
-import subprocess
 import tempfile
 
 import nox
@@ -71,34 +70,6 @@
 GCLOUD = str(CLOUD_SDK_INSTALL_DIR.joinpath("bin", "gcloud"))
 
 
-def _provision_kokoro_secrets():
-    """Downloads CI secrets directly from GCS and formats them for the tests."""
-    if not os.environ.get("KOKORO_GFILE_DIR"):
-        return
-
-    os.makedirs(DATA_DIR, exist_ok=True)
-
-    # Map GCS filenames to the local filenames expected by tests
-    secrets_map = {
-        "google-auth-service-account.json": "service_account.json",
-        "google-auth-authorized-user.json": "authorized_user.json",
-        "google-auth-impersonated-service-account.json": "impersonated_service_account.json",
-    }
-
-    gcs_base = "gs://cloud-devrel-kokoro-resources/google-cloud-python"
-
-    for src_name, dest_name in secrets_map.items():
-        subprocess.run(
-            ["gcloud", "storage", "cp", f"{gcs_base}/{src_name}", str(DATA_DIR)],
-            check=True,
-        )
-        # Rename to use underscores as per test conventions
-        (pathlib.Path(DATA_DIR) / src_name).replace(pathlib.Path(DATA_DIR) / dest_name)
-
-
-_provision_kokoro_secrets()
-
-
 # Cloud SDK helpers
 
 
