Prepare for switching accidental dev users to stable

diracdeltas · diracdeltas · commit ecac1ab8b051 · 2013-08-21T17:42:13.000-07:00
The 3.3.2 release had a bug that accidentally put some
percentage of stable users in the develoment branch. They
then updated to 4.0development.10. We need to push a
4.0development.11 release that detects which users used
to be on the stable branch and gives them a popup asking
them if they would like to go back to stable.
diff --git a/src/components/https-everywhere.js b/src/components/https-everywhere.js
@@ -503,6 +503,7 @@ HTTPSEverywhere.prototype = {
     } else if (topic == "sessionstore-windows-restored") {
       this.log(DBUG,"Got sessionstore-windows-restored");
       this.maybeShowObservatoryPopup();
+      this.maybeShowDevPopup();
     }
     return;
   },
@@ -527,6 +528,29 @@ HTTPSEverywhere.prototype = {
       ssl_observatory.registerProxyTestNotification(obs_popup_callback);
   },
 
+  maybeShowDevPopup: function() {
+    /*
+     * Users who installed 3.3.2 accidentally got upgraded to the
+     * dev branch. We need to push this code to a dev release so
+     * that they get a popup letting them know that they can switch
+     * back to the stable branch if they want.
+     */
+    var was_stable = true;
+    var shown = this.prefs.getBoolPref("dev_popup_shown");
+    try {
+      // this pref should exist only for people who used to be stable
+      // since getExperimentalFeatureCohort was never run in the
+      // development channel
+      this.prefs.getIntPref("experimental_feature_cohort");
+    } catch(e) {
+      was_stable = false;
+    }
+    if (was_stable && !shown) {
+      this.prefs.setBoolPref("dev_popup_shown", true);
+      this.chrome_opener("https://eff.org");
+    }
+  },
+
   getExperimentalFeatureCohort: function() {
     // This variable is used for gradually turning on features for testing and
     // scalability purposes.  It is a random integer [0,N_COHORTS) generated
diff --git a/src/defaults/preferences/preferences.js b/src/defaults/preferences/preferences.js
@@ -4,6 +4,9 @@ pref("extensions.https_everywhere.globalEnabled",true);
 // this is the HTTPS Everywhere preferences version (for migrations)
 pref("extensions.https_everywhere.prefs_version", 0);
 
+// this is a popup asking whether the user really meant to be on the dev branch
+pref("extensions.https_everywhere.dev_popup_shown", false);
+
 // SSl Observatory preferences
 pref("extensions.https_everywhere._observatory.enabled",false);
 
