Skip to content

Commit c55393e

Browse files
committed
Merge pull request EFForg#2720 from semenko/chrome-test-cleanups
Tiny Chrome test cleanups
2 parents ddb2347 + 0f510d2 commit c55393e

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Run the latest code and rulesets in a standalone Firefox profile:
1818

1919
Run the latest code and rulesets in a standalone Chromium profile:
2020

21-
bash run-chromium.sh
21+
bash test-chromium.sh --justrun
2222

2323
Build the Firefox extension as a .xpi package:
2424

test/chrome/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
- Python 2.7
44
- Selenium
5-
- Install Selenium as a python package using ```pip install selenium```, or run install-dev-dependencies and it will do the job
5+
- Install Selenium as a python package using ```pip install selenium```, or run install-dev-dependencies.sh and it will do the job
66
- ChromeDriver
7-
- Download ChromeDriver from here, https://sites.google.com/a/chromium.org/chromedriver/downloads. Extract the executable to /usr/bin, so that the pasted executable's full path becomes /usr/bin/chromedriver
7+
- Run ```apt-get install chromium-chromedriver```, or run install-dev-dependencies.sh
8+
- Or, manually download ChromeDriver from https://sites.google.com/a/chromium.org/chromedriver/downloads. Extract the executable to /usr/lib/chromium-browser/, so that the pasted executable's full path becomes /usr/lib/chromium-browser/chromedriver

test/chrome/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ class bcolors:
5050

5151
#Page Loaded
5252

53-
if driver.current_url.startswith('httaps'):
53+
if driver.current_url.startswith('https'):
5454
print bcolors.OKGREEN + "HTTP to HTTPS redirection successful" + bcolors.ENDC
55-
elif(driver.current_url.startswith('https')):
55+
elif(driver.current_url.startswith('http')):
5656
print bcolors.FAIL + "HTTP to HTTPS redirection failed" + bcolors.ENDC
5757
sys.exit(1)
5858

0 commit comments

Comments
 (0)