Validate rule.id before adding handler with it.

jsha · jsha · commit bf925e30cf23 · 2014-10-06T14:45:31.000-04:00
diff --git a/src/chrome/content/code/ApplicableList.js b/src/chrome/content/code/ApplicableList.js
@@ -212,6 +212,10 @@ ApplicableList.prototype = {
 
   add_command: function(rule) {
       var command = this.document.createElement("command");
+      if (typeof rule.id !== 'number') {
+        this.log(WARN, "Rule has invalid id " + rule.id);
+        return;
+      }
       command.setAttribute('id', rule.id+'-command');
       command.setAttribute('label', rule.name);
       command.setAttribute('oncommand', 'toggle_rule("'+rule.id+'")');
