Skip to content

Commit ae60b41

Browse files
committed
test/rules.sh: Use heredoc for printing multi-line message
Using a series of "echo" commands to print multi-line message is very noisy when run under "set -x". Replace "echo"s with a here-document, which is noise-free.
1 parent f59ab50 commit ae60b41

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

test/rules.sh

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,16 @@ if [ $# -gt 0 ] ; then
2929
fi
3030
if ! python2.7 test/rules/src/https_everywhere_checker/check_rules.py \
3131
test/rules/coverage.checker.config; then
32-
echo "Ruleset test coverage was insufficient."
33-
echo ""
34-
echo "Under the new ruleset testing rules (February 2015), any modified ruleset"
35-
echo "must have sufficient test coverage. You can often improve test coverage by"
36-
echo "adding <test url='...' /> tags, or by restructuring the rule to avoid"
37-
echo "wildcard <target> tags. See these documents:"
38-
echo "https://github.com/EFForg/https-everywhere/blob/master/ruleset-testing.md"
39-
echo "https://github.com/EFForg/https-everywhere/blob/master/ruleset-style.md"
32+
cat <<EOF
33+
Ruleset test coverage was insufficient.
34+
35+
Under the new ruleset testing rules (February 2015), any modified ruleset
36+
must have sufficient test coverage. You can often improve test coverage by
37+
adding <test url='...' /> tags, or by restructuring the rule to avoid
38+
wildcard <target> tags. See these documents:
39+
https://github.com/EFForg/https-everywhere/blob/master/ruleset-testing.md
40+
https://github.com/EFForg/https-everywhere/blob/master/ruleset-style.md
41+
EOF
4042
exit 1
4143
else
4244
exit 0

0 commit comments

Comments
 (0)