Skip to content

Commit 679feb3

Browse files
committed
Add an observatory preference for self-signed cert submission
1 parent f9bdf19 commit 679feb3

20 files changed

+86
-1
lines changed

src/chrome/content/observatory-preferences.xul

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
<command id="toggle-alt-roots" oncommand="toggle_alt_roots()" />
3636
<command id="toggle-send-asn" oncommand="toggle_send_asn()" />
3737
<command id="toggle-priv-dns" oncommand="toggle_priv_dns()" />
38+
<command id="toggle-self-signed" oncommand="toggle_self_signed()" />
3839
</commandset>
3940
<checkbox label="&ssl-observatory.prefs.use;" id="use-observatory"
4041
command="toggle-enabled" style="font-size:1.5em;"/>
@@ -74,6 +75,9 @@
7475
<tooltip id="priv-dns-tip" noautohide="true">
7576
<label>&ssl-observatory.prefs.priv_dns_tooltip;</label>
7677
</tooltip>
78+
<tooltip id="self-signed-tip" noautohide="true">
79+
<label>&ssl-observatory.prefs.self_signed_tooltip;</label>
80+
</tooltip>
7781
<vbox id="observatory-advanced-opts" hidden="true">
7882

7983
<groupbox hidden="true" tooltip="alt-roots-tip" >
@@ -88,6 +92,12 @@
8892
class="ssl-obs-conf" id="priv-dns"
8993
command="toggle-priv-dns"/>
9094
</groupbox>
95+
<groupbox hidden="true" tooltip="self-signed-tip">
96+
<caption hidden="true" label="&ssl-observatory.prefs.adv_priv_opts3;"/>
97+
<checkbox label="&ssl-observatory.prefs.self_signed;"
98+
class="ssl-obs-conf" id="self-signed"
99+
command="toggle-self-signed"/>
100+
</groupbox>
91101
</vbox>
92102
</vbox>
93103
<spacer flex="5" />

src/chrome/content/observatory-xul.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ function observatory_prefs_init(doc) {
2323
obsprefs.getBoolPref("extensions.https_everywhere._observatory.alt_roots");
2424
document.getElementById("priv-dns").checked =
2525
obsprefs.getBoolPref("extensions.https_everywhere._observatory.priv_dns");
26+
document.getElementById("self-signed").checked =
27+
obsprefs.getBoolPref("extensions.https_everywhere._observatory.self_signed");
2628
document.getElementById("send-asn").checked =
2729
obsprefs.getBoolPref("extensions.https_everywhere._observatory.send_asn");
2830

@@ -141,6 +143,11 @@ function toggle_priv_dns() {
141143
obsprefs.setBoolPref("extensions.https_everywhere._observatory.priv_dns", priv_dns);
142144
}
143145

146+
function toggle_self_signed() {
147+
var self_signed = document.getElementById("self-signed").checked;
148+
obsprefs.setBoolPref("extensions.https_everywhere._observatory.self_signed", self_signed);
149+
}
150+
144151
function observatory_prefs_accept() {
145152
// This is *horrid*, but
146153
// https://developer.mozilla.org/en/working_with_windows_in_chrome_code#Accessing_the_elements_of_the_top-level_document_from_a_child_window

src/chrome/locale/ar/ssl-observatory.dtd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,3 +82,7 @@ www.something.com, ولكن ليس من قام بالزيارة أو الصفح
8282

8383

8484

85+
<!ENTITY ssl-observatory.prefs.self_signed
86+
"Submit and check self-signed certificates">
87+
<!ENTITY ssl-observatory.prefs.self_signed
88+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

src/chrome/locale/de/ssl-observatory.dtd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,3 +90,7 @@ looked at. Mouseover the options for further details:">
9090
<!ENTITY ssl-observatory.warning.defense "If you are logged in to this site, it may be advisable to change your password once you have a safe connection.">
9191

9292

93+
<!ENTITY ssl-observatory.prefs.self_signed
94+
"Submit and check self-signed certificates">
95+
<!ENTITY ssl-observatory.prefs.self_signed
96+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

src/chrome/locale/en/ssl-observatory.dtd

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,4 +89,7 @@ looked at. Mouseover the options for further details:">
8989
<!ENTITY ssl-observatory.warning.text "EFF's SSL Observatory has issued a warning about the HTTPS certificiate(s) for this site:">
9090
<!ENTITY ssl-observatory.warning.defense "If you are logged in to this site, it may be advisable to change your password once you have a safe connection.">
9191

92-
92+
<!ENTITY ssl-observatory.prefs.self_signed
93+
"Submit and check self-signed certificates">
94+
<!ENTITY ssl-observatory.prefs.self_signed
95+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

src/chrome/locale/es/ssl-observatory.dtd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,3 +75,7 @@
7575
<!ENTITY ssl-observatory.warning.okay "Entiendo">
7676
<!ENTITY ssl-observatory.warning.text "El Observatorio SSL de EFF ha emitido una advertencia sobre el(los) certificado(s) para este sitio:">
7777
<!ENTITY ssl-observatory.warning.defense "Si está conectado a este sitio, es aconsejable cambiar tu contraseña una vez que tengas una conexión segura.">
78+
<!ENTITY ssl-observatory.prefs.self_signed
79+
"Submit and check self-signed certificates">
80+
<!ENTITY ssl-observatory.prefs.self_signed
81+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

src/chrome/locale/eu/ssl-observatory.dtd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,7 @@ Xehetasun gehiagorako pasa ezazu sagua aukeren gainetik:">
8585
<!ENTITY ssl-observatory.warning.defense "Leku honetan saioa hasi baduzu, konexio seguru bat duzunean zure pasahitza aldatzea komeni da.">
8686

8787

88+
<!ENTITY ssl-observatory.prefs.self_signed
89+
"Submit and check self-signed certificates">
90+
<!ENTITY ssl-observatory.prefs.self_signed
91+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

src/chrome/locale/fa/ssl-observatory.dtd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,7 @@
7777
<!ENTITY ssl-observatory.warning.defense "اگر شما در این وب‌سایت لاگین کرده‌اید، پیشنهاد می‌کنیم که زمانی که با یک اتصال امن وارد شدید رمز ورود خود را تغییر دهید.">
7878

7979

80+
<!ENTITY ssl-observatory.prefs.self_signed
81+
"Submit and check self-signed certificates">
82+
<!ENTITY ssl-observatory.prefs.self_signed
83+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

src/chrome/locale/fr/ssl-observatory.dtd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,3 +87,7 @@ www.something.com, mais pas qui a visité le site, ou quelle page a été lue. P
8787
<!ENTITY ssl-observatory.warning.defense "Si vous vous êtes connecté à ce site, vous devriez changer de mot de passe dès que vous retrouvez une connexion sécurisée.">
8888

8989

90+
<!ENTITY ssl-observatory.prefs.self_signed
91+
"Submit and check self-signed certificates">
92+
<!ENTITY ssl-observatory.prefs.self_signed
93+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

src/chrome/locale/lt/ssl-observatory.dtd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,3 +80,7 @@ bet ne tai, kas aplankė svetainę, ar kokį konkrečiai puslapį jie
8080
<!ENTITY ssl-observatory.warning.defense "Jei esate prisiregistravę prie šios svetainės, patartina pasikeisti slaptažodį, kai turėsite saugų ryšį.">
8181

8282

83+
<!ENTITY ssl-observatory.prefs.self_signed
84+
"Submit and check self-signed certificates">
85+
<!ENTITY ssl-observatory.prefs.self_signed
86+
"This is recommended; cryptographic problems are especially common in self-signed embedded devices">

0 commit comments

Comments
 (0)