Preliminary ruleset test instructions, and made it so menu item only appears once

Micah Lee · Micah Lee · commit 05c38653bfeb · 2013-11-11T17:48:25.000-08:00
diff --git a/README.md b/README.md
@@ -37,6 +37,13 @@ To build the Chrome version go to the git repository root and run:
 
 After building the extension the xpi files (for Firefox) and crx files (for Chrome) get created in the pkg directory. You can open those files within your browser to install the browser extension.
 
+Ruleset Tests
+-------------
+
+You can run ruleset tests by opening `about:config` and changing `extensions.https_everywhere.show_ruleset_tests` to true. Now when you open the HTTPS Everywhere context menu there will be a "Run HTTPS Everywhere Ruleset Tests" menu item.
+
+When you run the tests, be prepared to let your computer run them for a really long time.
+
 Source Tree
 -----------
 
diff --git a/src/chrome/content/toolbar_button.js b/src/chrome/content/toolbar_button.js
@@ -199,6 +199,8 @@ function stitch_context_menu2() {
   }
 }
 
+var rulesetTestsMenuItem = null;
+
 function show_applicable_list(menupopup) {
   var domWin = content.document.defaultView.top;
   if (!(domWin instanceof CI.nsIDOMWindow)) {
@@ -220,14 +222,18 @@ function show_applicable_list(menupopup) {
 
   // should we also show the ruleset tests menu item?
   if(HTTPSEverywhere.prefs.getBoolPref("show_ruleset_tests")) {
-    let strings = document.getElementById('HttpsEverywhereStrings');
-    let label = strings.getString('https-everywhere.menu.ruleset-tests');
 
-    let item = this.document.createElement('menuitem');
-    item.setAttribute('command', 'https-everywhere-menuitem-ruleset-tests');
-    item.setAttribute('label', label);
+    if(!rulesetTestsMenuItem) {
+      let strings = document.getElementById('HttpsEverywhereStrings');
+      let label = strings.getString('https-everywhere.menu.ruleset-tests');
+
+      rulesetTestsMenuItem = this.document.createElement('menuitem');
+      rulesetTestsMenuItem.setAttribute('command', 'https-everywhere-menuitem-ruleset-tests');
+      rulesetTestsMenuItem.setAttribute('label', label);
+    }
 
-    menupopup.appendChild(item);
+    if(!menupopup.contains(rulesetTestsMenuItem)) 
+      menupopup.appendChild(rulesetTestsMenuItem);
   }
   
 }
