[CID 15180] MCPolygonEditTool::handler_under_point(): Free using delete[]

peter-b · peter-b · commit 5d4ab05cd7ef · 2015-03-09T16:19:16.000Z
diff --git a/engine/src/edittool.cpp b/engine/src/edittool.cpp
@@ -320,11 +320,11 @@ uint4 MCPolygonEditTool::handle_under_point(int2 x, int2 y)
 	for (uint4 i=0; i<npts; i++)
 		if (MCU_point_in_rect(rects[i], x, y))
 		{
-			delete rects;
+			delete[] rects;
 			return i;
 		}
 
-	delete rects;
+	delete[] rects;
 	return -1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -320,11 +320,11 @@ uint4 MCPolygonEditTool::handle_under_point(int2 x, int2 y)`
`320`	`320`	`for (uint4 i=0; i<npts; i++)`
`321`	`321`	`if (MCU_point_in_rect(rects[i], x, y))`
`322`	`322`	`{`
`323`		`- delete rects;`
	`323`	`+ delete[] rects;`
`324`	`324`	`return i;`
`325`	`325`	`}`
`326`	`326`
`327`		`- delete rects;`
	`327`	`+ delete[] rects;`
`328`	`328`	`return -1;`
`329`	`329`	`}`
`330`	`330`