Enable reaction-avatars on organization discussions (refined-github#6316)

fregante · web-flow · commit bfc8c110eec7 · 2023-02-11T15:39:44.000+08:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -55,7 +55,7 @@
 		"filter-altered-clicks": "^2.0.0",
 		"fit-textarea": "^2.0.0",
 		"flat-zip": "^1.0.1",
-		"github-url-detection": "^6.1.0",
+		"github-url-detection": "^7.0.1-0",
 		"image-promise": "^7.0.1",
 		"indent-textarea": "^2.1.1",
 		"js-abbreviation-number": "^1.4.0",
diff --git a/source/features/reactions-avatars.tsx b/source/features/reactions-avatars.tsx
@@ -58,7 +58,8 @@ const viewportObserver = new IntersectionObserver(changes => {
 });
 
 function showAvatarsOn(commentReactions: Element): void {
-	const avatarLimit = arbitraryAvatarLimit - (commentReactions.children.length * approximateHeaderLength);
+	const reactionTypes = select.all('.social-reaction-summary-item', commentReactions).length;
+	const avatarLimit = arbitraryAvatarLimit - (reactionTypes * approximateHeaderLength);
 
 	const participantByReaction = select
 		.all(':scope > button.social-reaction-summary-item', commentReactions)
@@ -74,35 +75,30 @@ function showAvatarsOn(commentReactions: Element): void {
 	}
 }
 
-// TODO [2022-12-18]: Drop `.comment-reactions-options` (GHE)
-const reactionsSelector = '.has-reactions :is(.js-comment-reactions-options, .comment-reactions-options):not(.rgh-reactions)';
-
 function observeCommentReactions(commentReactions: Element): void {
-	commentReactions.classList.add('rgh-reactions');
 	viewportObserver.observe(commentReactions);
 }
 
 function init(signal: AbortSignal): void {
-	observe(reactionsSelector, observeCommentReactions, {signal});
-	onAbort(signal, viewportObserver);
-}
-
-function discussionInit(signal: AbortSignal): void {
-	observe(reactionsSelector, observeCommentReactions, {signal});
+	observe('.has-reactions .js-comment-reactions-options', observeCommentReactions, {signal});
 	onAbort(signal, viewportObserver);
 }
 
 void features.add(import.meta.url, {
 	include: [
 		pageDetect.hasComments,
 		pageDetect.isReleasesOrTags,
-	],
-	awaitDomReady: false,
-	init,
-}, {
-	include: [
 		pageDetect.isDiscussion,
 	],
 	awaitDomReady: false,
-	init: discussionInit,
+	init,
 });
+
+/*
+Test URLs
+
+https://github.com/refined-github/refined-github/pull/4119
+https://github.com/parcel-bundler/parcel/discussions/6490
+https://github.com/orgs/community/discussions/11202
+
+*/
