Skip to content

Commit dda37ee

Browse files
dbolducdbolduc
authored
feat(apikeys): declare GA (googleapis#10925)
1 parent 99c1165 commit dda37ee

9 files changed

Lines changed: 22 additions & 23 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ We are happy to announce the following GA libraries. Unless specifically noted,
124124
the APIs in these libraries are stable, and are ready for production use.
125125

126126
- [Advisory Notifications](/google/cloud/advisorynotifications/README.md)
127+
- [API Keys](/google/cloud/apikeys/README.md)
127128

128129
### [TPU](/google/cloud/tpu/README.md)
129130

‎README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ See each library's `README.md` file for more information about:
105105
- [Apigee Connect API](google/cloud/apigeeconnect/README.md)
106106
[\[quickstart\]](google/cloud/apigeeconnect/quickstart/README.md)
107107
[\[reference\]](https://googleapis.dev/cpp/google-cloud-apigeeconnect/latest)
108+
- [API Keys API](google/cloud/apikeys/README.md)
109+
[\[quickstart\]](google/cloud/apikeys/quickstart/README.md)
110+
[\[reference\]](https://googleapis.dev/cpp/google-cloud-apikeys/latest)
108111
- [App Engine Admin API](google/cloud/appengine/README.md)
109112
[\[quickstart\]](google/cloud/appengine/quickstart/README.md)
110113
[\[reference\]](https://googleapis.dev/cpp/google-cloud-appengine/latest)

‎ci/abi-dumps/google_cloud_cpp_apikeys.expected.abi.dump.gz‎

435 KB
Binary file not shown.

‎cmake/GoogleCloudCppFeatures.cmake‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,13 @@ include(CreateBazelConfig)
2323
set(GOOGLE_CLOUD_CPP_LEGACY_FEATURES
2424
"bigtable;bigquery;iam;logging;pubsub;spanner;storage")
2525

26-
set(GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES
27-
# cmake-format: sorted
28-
# Introduced circa 2022-08-17
29-
"apikeys"
26+
set(GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES # cmake-format: sorted
3027
# This is WIP, it needs a number of hand-crafted APIs.
3128
"pubsublite")
3229

3330
set(GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES # cmake-format: sorted
34-
)
31+
# Transitioned circa 2023-02-22
32+
"apikeys")
3533

3634
set(GOOGLE_CLOUD_CPP_GA_LIBRARIES
3735
# cmake-format: sorted

‎google/cloud/apikeys/CMakeLists.txt‎

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
include(GoogleapisConfig)
1818
set(DOXYGEN_PROJECT_NAME "API Keys API C++ Client")
1919
set(DOXYGEN_PROJECT_BRIEF "A C++ Client Library for the API Keys API")
20-
set(DOXYGEN_PROJECT_NUMBER "${PROJECT_VERSION} (Experimental)")
20+
set(DOXYGEN_PROJECT_NUMBER "${PROJECT_VERSION}")
2121
set(DOXYGEN_EXCLUDE_SYMBOLS "internal" "apikeys_internal" "apikeys_testing"
2222
"examples")
2323
set(DOXYGEN_EXAMPLE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/samples
@@ -62,14 +62,13 @@ target_link_libraries(
6262
google_cloud_cpp_add_common_options(google_cloud_cpp_apikeys)
6363
set_target_properties(
6464
google_cloud_cpp_apikeys
65-
PROPERTIES EXPORT_NAME google-cloud-cpp::experimental-apikeys
65+
PROPERTIES EXPORT_NAME google-cloud-cpp::apikeys
6666
VERSION "${PROJECT_VERSION}"
6767
SOVERSION "${PROJECT_VERSION_MAJOR}")
6868
target_compile_options(google_cloud_cpp_apikeys
6969
PUBLIC ${GOOGLE_CLOUD_CPP_EXCEPTIONS_FLAG})
7070

71-
add_library(google-cloud-cpp::experimental-apikeys ALIAS
72-
google_cloud_cpp_apikeys)
71+
add_library(google-cloud-cpp::apikeys ALIAS google_cloud_cpp_apikeys)
7372

7473
# Create a header-only library for the mocks. We use a CMake `INTERFACE` library
7574
# for these, a regular library would not work on macOS (where the library needs
@@ -88,11 +87,10 @@ add_library(google_cloud_cpp_apikeys_mocks INTERFACE)
8887
target_sources(google_cloud_cpp_apikeys_mocks INTERFACE ${mock_files})
8988
target_link_libraries(
9089
google_cloud_cpp_apikeys_mocks
91-
INTERFACE google-cloud-cpp::experimental-apikeys GTest::gmock_main
92-
GTest::gmock GTest::gtest)
93-
set_target_properties(
94-
google_cloud_cpp_apikeys_mocks
95-
PROPERTIES EXPORT_NAME google-cloud-cpp::experimental-apikeys_mocks)
90+
INTERFACE google-cloud-cpp::apikeys GTest::gmock_main GTest::gmock
91+
GTest::gtest)
92+
set_target_properties(google_cloud_cpp_apikeys_mocks
93+
PROPERTIES EXPORT_NAME google-cloud-cpp::apikeys_mocks)
9694
target_include_directories(
9795
google_cloud_cpp_apikeys_mocks
9896
INTERFACE $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
@@ -104,8 +102,7 @@ target_compile_options(google_cloud_cpp_apikeys_mocks
104102
include(CTest)
105103
if (BUILD_TESTING)
106104
add_executable(apikeys_quickstart "quickstart/quickstart.cc")
107-
target_link_libraries(apikeys_quickstart
108-
PRIVATE google-cloud-cpp::experimental-apikeys)
105+
target_link_libraries(apikeys_quickstart PRIVATE google-cloud-cpp::apikeys)
109106
google_cloud_cpp_add_common_options(apikeys_quickstart)
110107
add_test(
111108
NAME apikeys_quickstart

‎google/cloud/apikeys/README.md‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
# API Keys API C++ Client Library
22

3-
:construction:
4-
53
This directory contains an idiomatic C++ client library for the
64
[API Keys API][cloud-service-docs], a service to manage the API keys associated
75
with developer projects.
86

9-
This library is **experimental**. Its APIs are subject to change without notice.
10-
11-
Please note that the Google Cloud C++ client libraries do **not** follow
7+
While this library is **GA**, please note that the Google Cloud C++ client libraries do **not** follow
128
[Semantic Versioning](https://semver.org/).
139

1410
## Quickstart

‎google/cloud/apikeys/config.cmake.in‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,7 @@ find_dependency(google_cloud_cpp_grpc_utils)
2020
find_dependency(absl)
2121

2222
include("${CMAKE_CURRENT_LIST_DIR}/google_cloud_cpp_apikeys-targets.cmake")
23+
24+
if (NOT TARGET google-cloud-cpp::experimental-apikeys)
25+
add_library(google-cloud-cpp::experimental-apikeys ALIAS google-cloud-cpp::apikeys)
26+
endif ()

‎google/cloud/apikeys/doc/main.dox‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
An idiomatic C++ client library for the [API Keys API][cloud-service-docs], a
66
service to manage the API keys associated with developer projects.
77

8-
This library is **experimental**. Its APIs are subject to change without notice.
8+
While this library is **GA**, please note Google Cloud C++ client libraries do **not** follow [Semantic Versioning](https://semver.org/).
99

1010
This library requires a C++14 compiler. It is supported (and tested) on multiple
1111
Linux distributions, as well as Windows and macOS. The [README][github-readme]

‎libraries.bzl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717
"""Automatically generated unit tests list - DO NOT EDIT."""
1818

1919
GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES = [
20-
"apikeys",
2120
"pubsublite",
2221
]
2322

2423
GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES = [
24+
"apikeys",
2525
]
2626

2727
GOOGLE_CLOUD_CPP_GA_LIBRARIES = [

0 commit comments

Comments
 (0)