Missing Name Mappings Cause Failure

nebhale · nebhale · commit 8b42f77d3f12 · 2017-07-19T12:27:24.000-07:00
Previously, missing name mappings in the versions tasks would show up with
UNKNOWN. This was easy to miss in the CI system, leading them to be unset
when release time came around. This change ensures that missing name mappings
cause a failure forcing it to be dealt with early.
diff --git a/rakelib/versions_task.rb b/rakelib/versions_task.rb
@@ -179,9 +179,12 @@ def dependency_versions
         index_configuration(configuration).each do |index_configuration|
           version, uri = get_from_cache(cache, configuration, index_configuration)
 
+          name = NAME_MAPPINGS[id]
+          raise "Unable to resolve name for '#{id}'" unless name
+
           dependency_versions << {
             'id'      => id,
-            'name'    => NAME_MAPPINGS[id] || "UNKNOWN (#{id})",
+            'name'    => name,
             'uri'     => uri,
             'version' => version
           }
