From 47628ffd198ba178164da5c761954c589cf59fa4 Mon Sep 17 00:00:00 2001 From: Roni1993 Date: Tue, 11 Jun 2019 17:01:45 +0200 Subject: [PATCH] Provide Exception message for wrong Schema When a user provides a schema in the RespositoryName he receives the InvalidRepositoryNameException without an meaningful explanation. This leads to confusion. I had to look up the source to understand why this exception was thrown. --- src/main/java/com/github/dockerjava/core/NameParser.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/com/github/dockerjava/core/NameParser.java b/src/main/java/com/github/dockerjava/core/NameParser.java index c592684be..ffadb6656 100644 --- a/src/main/java/com/github/dockerjava/core/NameParser.java +++ b/src/main/java/com/github/dockerjava/core/NameParser.java @@ -100,8 +100,7 @@ public static void validateRepoName(String name) { public static HostnameReposName resolveRepositoryName(String reposName) { if (reposName.contains("://")) { - // It cannot contain a scheme! - throw new InvalidRepositoryNameException(); + throw new InvalidRepositoryNameException("RepositoryName shouldn't contain a scheme"); } String[] nameParts = reposName.split("/", 2);