com.github.dockerjava.api.model.PullResponseItem#isPullSuccessIndicated fails to check for "Exists" status #2010

Activity

1. AndyGee commented on Nov 22, 2022

   

   AndyGee

   on Nov 22, 2022

   Last edited by eddumelendez

   Author

   More actions

   Quick fix was to create this class in my test classpath:

   package com.github.dockerjava.api.model;
   
   import com.fasterxml.jackson.annotation.JsonIgnore;
   
   /**
    * Represents a pull response stream item
    */
   public class PullResponseItem extends com.github.dockerjava.api.model.ResponseItem {
   
     private static final long serialVersionUID = -2575482839766823293L;
   
     private static final String LEGACY_REGISTRY = "this image was pulled from a legacy registry";
   
     private static final String DOWNLOADED_NEWER_IMAGE = "Downloaded newer image";
   
     private static final String IMAGE_UP_TO_DATE = "Image is up to date";
   
     private static final String DOWNLOAD_COMPLETE = "Download complete";
   
     private static final String DOWNLOADED_SWARM = ": downloaded";
   
     private static final String EXISTS = "Exists";
   
     /**
      * Returns whether the status indicates a successful pull operation
      *
      * @returns true: status indicates that pull was successful, false: status doesn't indicate a successful pull
      */
     @JsonIgnore
     public boolean isPullSuccessIndicated() {
       if (isErrorIndicated() || getStatus() == null) {
         return false;
       }
   
       return (
         getStatus().contains(DOWNLOAD_COMPLETE)
           || getStatus().contains(IMAGE_UP_TO_DATE)
           || getStatus().contains(DOWNLOADED_NEWER_IMAGE)
           || getStatus().contains(LEGACY_REGISTRY)
           || getStatus().contains(DOWNLOADED_SWARM)
           || getStatus().contains(EXISTS));
     }
   }
2. eddumelendez commented on Nov 23, 2022

   

   eddumelendez

   on Nov 23, 2022

   Member

   More actions

   @AndyGee thanks for reporting this issue! is the full status Already exists? I look at moby and just found that one.
3. AndyGee commented on Jan 23, 2023

   

   AndyGee

   on Jan 23, 2023

   Author

   More actions

   @eddumelendez Sorry for the late reply. On Win at least, it is "Exists" - However, I'm currently using the above workaround in all our projects, which are also built on ios and ubuntu based systems.
4. AndyGee commented on Jan 23, 2023

   

   AndyGee

   on Jan 23, 2023

   Author

   More actions

   @eddumelendez another workaround is of course to delete the image, but that's kind of drastic ;-) - Interestingly the IMAGE_UP_TO_DATE is not the status here, which is what I'd expect given that the image is actually up to date.
5. AndyGee commented on Jan 23, 2023

   

   AndyGee

   on Jan 23, 2023

   Author

   More actions

   
6. stale commented on Apr 26, 2023

   

   stalebot

   on Apr 26, 2023

   More actions

   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
7. stale

   added

   resolution/stale

   on Apr 26, 2023
8. eddumelendez

   removed

   resolution/stale

   on Apr 26, 2023
9. stale commented on Aug 12, 2023

   

   stalebot

   on Aug 12, 2023

   More actions

   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
10. stale

    added

    resolution/stale

    on Aug 12, 2023
11. eddumelendez

    closed this as completedin #2335on Jul 9, 2024