Apparently not only OkHttp:

docker-java/docker-java-core/src/main/java/com/github/dockerjava/core/KeystoreSSLConfig.java

Lines 91 to 130 in 74a4479

    
               context.init(keyManagerFactory.getKeyManagers(), new TrustManager[] { 
        
                       new X509TrustManager() { 
        
                           @Override 
        
                           public X509Certificate[] getAcceptedIssuers() { 
        
                               return new X509Certificate[] {}; 
        
                           } 
        
                           @Override 
        
                           public void checkClientTrusted(final X509Certificate[] arg0, final String arg1) { 
        
                           } 
        
                           @Override 
        
                           public void checkServerTrusted(final X509Certificate[] arg0, final String arg1) { 
        
                           } 
        
                       } 
        
               }, new SecureRandom()); 
        
               return context; 
        
           } 
        
           @Override 
        
           public boolean equals(Object o) { 
        
               if (this == o) { 
        
                   return true; 
        
               } 
        
               if (o == null || getClass() != o.getClass()) { 
        
                   return false; 
        
               } 
        
               KeystoreSSLConfig that = (KeystoreSSLConfig) o; 
        
               return keystore.equals(that.keystore); 
        
           } 
        
           @Override 
        
           public int hashCode() { 
        
               return keystore.hashCode();

	context.init(keyManagerFactory.getKeyManagers(), new TrustManager[] {
	new X509TrustManager() {
	@Override
	public X509Certificate[] getAcceptedIssuers() {
	return new X509Certificate[] {};
	}

	@Override
	public void checkClientTrusted(final X509Certificate[] arg0, final String arg1) {

	}

	@Override
	public void checkServerTrusted(final X509Certificate[] arg0, final String arg1) {

	}
	}
	}, new SecureRandom());

	return context;
	}

	@Override
	public boolean equals(Object o) {
	if (this == o) {
	return true;
	}
	if (o == null \|\| getClass() != o.getClass()) {
	return false;
	}

	KeystoreSSLConfig that = (KeystoreSSLConfig) o;

	return keystore.equals(that.keystore);

	}

	@Override
	public int hashCode() {
	return keystore.hashCode();

Uh oh!

TrustAll Trust Manager in OkHttp is questionable #1352

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions