Skip to content

Commit ffb12c9

Browse files
committed
update default value and test case
1 parent f77fcf4 commit ffb12c9

3 files changed

Lines changed: 16 additions & 7 deletions

File tree

‎src/main/java/com/github/dockerjava/api/model/EndpointSpec.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class EndpointSpec implements Serializable {
2121
* @since 1.24
2222
*/
2323
@JsonProperty("Mode")
24-
EndpointResolutionMode mode;
24+
EndpointResolutionMode mode=EndpointResolutionMode.VIP;
2525

2626
/**
2727
* @since 1.24

‎src/main/java/com/github/dockerjava/api/model/TaskSpec.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ public class TaskSpec implements Serializable {
5050

5151
/**
5252
* @since 1.24
53-
* a counter that triggers an update even if no relevant parameters have been changed
54-
* a random value will work if it is incrementing.
53+
* a counter that triggers an update even if no relevant parameters have been changed
54+
* a random value will work if it is incrementing.
5555
*/
5656
@JsonProperty("ForceUpdate")
57-
private Integer forceUpdate;
57+
private Integer forceUpdate = 0;
5858

5959
/**
6060
* @see #containerSpec

‎src/test/java/com/github/dockerjava/cmd/swarm/CreateServiceCmdExecIT.java‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,18 @@
22

33
import com.github.dockerjava.api.exception.DockerException;
44
import com.github.dockerjava.api.model.ContainerSpec;
5+
import com.github.dockerjava.api.model.EndpointSpec;
56
import com.github.dockerjava.api.model.Network;
67
import com.github.dockerjava.api.model.NetworkAttachmentConfig;
8+
import com.github.dockerjava.api.model.PortConfig;
9+
import com.github.dockerjava.api.model.PortConfigProtocol;
710
import com.github.dockerjava.api.model.Service;
811
import com.github.dockerjava.api.model.ServiceModeConfig;
912
import com.github.dockerjava.api.model.ServiceReplicatedModeOptions;
1013
import com.github.dockerjava.api.model.ServiceSpec;
1114
import com.github.dockerjava.api.model.SwarmSpec;
1215
import com.github.dockerjava.api.model.TaskSpec;
16+
import com.google.common.collect.ImmutableMap;
1317
import com.google.common.collect.Lists;
1418
import org.junit.Test;
1519
import org.slf4j.Logger;
@@ -26,7 +30,7 @@ public class CreateServiceCmdExecIT extends SwarmCmdIT {
2630

2731
public static final Logger LOG = LoggerFactory.getLogger(CreateServiceCmdExecIT.class);
2832
private static final String SERVICE_NAME = "theservice";
29-
33+
3034
@Test
3135
public void testCreateService() throws DockerException {
3236
dockerRule.getClient().initializeSwarmCmd(new SwarmSpec())
@@ -62,7 +66,6 @@ public void testCreateServiceWithNetworks() {
6266
.withIpam(new Network.Ipam()
6367
.withDriver("default"))
6468
.exec().getId();
65-
6669
ServiceSpec spec = new ServiceSpec()
6770
.withName(SERVICE_NAME)
6871
.withTaskTemplate(new TaskSpec()
@@ -74,10 +77,16 @@ public void testCreateServiceWithNetworks() {
7477
.withTarget(networkId)
7578
.withAliases(Lists.<String>newArrayList("alias1", "alias2"))
7679
))
80+
.withLabels(ImmutableMap.of("com.docker.java.usage","SwarmServiceIT"))
7781
.withMode(new ServiceModeConfig().withReplicated(
7882
new ServiceReplicatedModeOptions()
7983
.withReplicas(1)
80-
));
84+
)).withEndpointSpec(new EndpointSpec()
85+
.withPorts(Lists.<PortConfig>newArrayList(new PortConfig()
86+
.withPublishMode(PortConfig.PublishMode.host)
87+
.withPublishedPort(22)
88+
.withProtocol(PortConfigProtocol.TCP)
89+
)));
8190

8291
dockerRule.getClient().createServiceCmd(spec).exec();
8392

0 commit comments

Comments
 (0)