Fixed startContainer use cases

patelrit · patelrit · commit c9eec27e8679 · 2014-07-14T19:28:50.000-07:00
Using top command instead of true so that the container keeps running
and returns the valid state
diff --git a/src/test/java/com/github/dockerjava/client/command/StartContainerCmdTest.java b/src/test/java/com/github/dockerjava/client/command/StartContainerCmdTest.java
@@ -82,6 +82,7 @@ public void startContainerWithVolumes() throws DockerException {
 		containerInspectResponse = dockerClient.inspectContainerCmd(container
 				.getId()).exec();
 		
+
 		assertThat(Arrays.asList(containerInspectResponse.getVolumes()),
 				contains(volume1, volume2));
 
@@ -99,7 +100,7 @@ public void startContainerWithPortBindings() throws DockerException {
 		
 		ContainerCreateResponse container = dockerClient
 				.createContainerCmd("busybox")
-				.withCmd("true").withExposedPorts(tcp22, tcp23).exec();
+				.withCmd("top").withExposedPorts(tcp22, tcp23).exec();
 
 		LOG.info("Created container {}", container.toString());
 
@@ -116,6 +117,8 @@ public void startContainerWithPortBindings() throws DockerException {
 
 		containerInspectResponse = dockerClient.inspectContainerCmd(container
 				.getId()).exec();
+
+		assertThat(containerInspectResponse.getState().isRunning(), is(true));
 		
 		assertThat(Arrays.asList(containerInspectResponse.getConfig().getExposedPorts()),
 				contains(tcp22, tcp23));
@@ -133,7 +136,7 @@ public void startContainerWithPortBindings() throws DockerException {
 	public void startContainer() throws DockerException {
 
 		ContainerCreateResponse container = dockerClient
-				.createContainerCmd("busybox").withCmd(new String[] { "true" }).exec();
+				.createContainerCmd("busybox").withCmd(new String[] { "top" }).exec();
 		
 		LOG.info("Created container {}", container.toString());
 		assertThat(container.getId(), not(isEmptyString()));
