Fix memory leak risk by using disableConnectionState() to disable httpclient connection state tracking (HttpClient transport) (#1559)

internalerror · internalerror · commit 3dffc0fd53ce · 2021-03-16T23:55:11.000+08:00
diff --git a/docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/ApacheDockerHttpClientImpl.java b/docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/ApacheDockerHttpClientImpl.java
@@ -91,6 +91,7 @@ protected ApacheDockerHttpClientImpl(
         httpClient = HttpClients.custom()
             .setRequestExecutor(new HijackingHttpRequestExecutor(null))
             .setConnectionManager(connectionManager)
+            .disableConnectionState()
             .build();
     }
 
diff --git a/docs/getting_started.md b/docs/getting_started.md
@@ -90,6 +90,7 @@ DockerClientConfig config = ...;
 DockerHttpClient httpClient = new ApacheDockerHttpClient.Builder()
     .dockerHost(config.getDockerHost())
     .sslConfig(config.getSSLConfig())
+    .maxConnections(100)
     .build();
 ```
 
@@ -118,4 +119,4 @@ DockerClient dockerClient = DockerClientImpl.getInstance(config, httpClient);
 Once you have it, you can start executing Docker commands:
 ```java
 dockerClient.pingCmd().exec();
-```
+```

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,7 @@ protected ApacheDockerHttpClientImpl(`
`91`	`91`	`httpClient = HttpClients.custom()`
`92`	`92`	`.setRequestExecutor(new HijackingHttpRequestExecutor(null))`
`93`	`93`	`.setConnectionManager(connectionManager)`
	`94`	`+ .disableConnectionState()`
`94`	`95`	`.build();`
`95`	`96`	`}`
`96`	`97`