Checkstyle: redundant lines.

KostyaSha · KostyaSha · commit 01f82d2c2c4f · 2016-02-02T18:03:49.000+03:00
Disabled for now.
diff --git a/src/main/java/com/github/dockerjava/api/command/AsyncDockerCmd.java b/src/main/java/com/github/dockerjava/api/command/AsyncDockerCmd.java
@@ -13,6 +13,6 @@
  */
 public interface AsyncDockerCmd<CMD_T extends AsyncDockerCmd<CMD_T, A_RES_T>, A_RES_T> extends DockerCmd<Void> {
 
-    public <T extends ResultCallback<A_RES_T>> T exec(T resultCallback);
+    <T extends ResultCallback<A_RES_T>> T exec(T resultCallback);
 
 }
diff --git a/src/main/java/com/github/dockerjava/api/command/AttachContainerCmd.java b/src/main/java/com/github/dockerjava/api/command/AttachContainerCmd.java
@@ -26,46 +26,46 @@
 public interface AttachContainerCmd extends AsyncDockerCmd<AttachContainerCmd, Frame> {
 
     @CheckForNull
-    public String getContainerId();
+    String getContainerId();
 
     @CheckForNull
-    public Boolean hasLogsEnabled();
+    Boolean hasLogsEnabled();
 
     @CheckForNull
-    public Boolean hasFollowStreamEnabled();
+    Boolean hasFollowStreamEnabled();
 
     @CheckForNull
-    public Boolean hasTimestampsEnabled();
+    Boolean hasTimestampsEnabled();
 
     @CheckForNull
-    public Boolean hasStdoutEnabled();
+    Boolean hasStdoutEnabled();
 
     @CheckForNull
-    public Boolean hasStderrEnabled();
+    Boolean hasStderrEnabled();
 
     @CheckForNull
-    public InputStream getStdin();
+    InputStream getStdin();
 
-    public AttachContainerCmd withContainerId(@Nonnull String containerId);
+    AttachContainerCmd withContainerId(@Nonnull String containerId);
 
     /**
      * Following the stream means the resulting {@link InputStream} returned by {@link #exec()} reads infinitely. So a
      * {@link InputStream#read()} MAY BLOCK FOREVER as long as no data is streamed from the docker host to
      * {@link DockerClient}!
      */
-    public AttachContainerCmd withFollowStream(Boolean followStream);
+    AttachContainerCmd withFollowStream(Boolean followStream);
 
-    public AttachContainerCmd withTimestamps(Boolean timestamps);
+    AttachContainerCmd withTimestamps(Boolean timestamps);
 
-    public AttachContainerCmd withStdOut(Boolean stdout);
+    AttachContainerCmd withStdOut(Boolean stdout);
 
-    public AttachContainerCmd withStdErr(Boolean stderr);
+    AttachContainerCmd withStdErr(Boolean stderr);
 
-    public AttachContainerCmd withStdIn(InputStream stdin);
+    AttachContainerCmd withStdIn(InputStream stdin);
 
-    public AttachContainerCmd withLogs(Boolean logs);
+    AttachContainerCmd withLogs(Boolean logs);
 
-    public static interface Exec extends DockerCmdAsyncExec<AttachContainerCmd, Frame> {
+    interface Exec extends DockerCmdAsyncExec<AttachContainerCmd, Frame> {
     }
 
 }
diff --git a/src/test/resources/checkstyle/checkstyle-config.xml b/src/test/resources/checkstyle/checkstyle-config.xml
@@ -113,6 +113,10 @@
         <!-- some weirdness with logger in CommitCmdExec and CreateImageCmdExec -->
         <!--<module name="WhitespaceAround"/>-->
 
+        <!-- Modifier Checks                                    -->
+        <!-- Verify with @marcuslinke before. 576 violations -->
+        <!--<module name="RedundantModifier"/>-->
+
     </module>
 
 </module>

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,6 @@`
`13`	`13`	`*/`
`14`	`14`	`public interface AsyncDockerCmd<CMD_T extends AsyncDockerCmd<CMD_T, A_RES_T>, A_RES_T> extends DockerCmd<Void> {`
`15`	`15`
`16`		`- public <T extends ResultCallback<A_RES_T>> T exec(T resultCallback);`
	`16`	`+ <T extends ResultCallback<A_RES_T>> T exec(T resultCallback);`
`17`	`17`
`18`	`18`	`}`